Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Unified Diff: third_party/WebKit/Source/core/editing/commands/EditCommand.cpp

Issue 2451093002: Get rid of EditCommand::setEndingSelection() taking one VisiblePosition (Closed)
Patch Set: 2016-10-26T16:39:39 Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/editing/commands/EditCommand.cpp
diff --git a/third_party/WebKit/Source/core/editing/commands/EditCommand.cpp b/third_party/WebKit/Source/core/editing/commands/EditCommand.cpp
index cd04c02d913e15c8e04649f9a77416b9f80af0b6..7cf80e0d7ea311cb5d4ae85d82de0ac717e5771c 100644
--- a/third_party/WebKit/Source/core/editing/commands/EditCommand.cpp
+++ b/third_party/WebKit/Source/core/editing/commands/EditCommand.cpp
@@ -94,18 +94,6 @@ void EditCommand::setEndingSelection(const VisibleSelection& selection) {
}
}
-// TODO(yosin): We will make |SelectionInDOMTree| version of
-// |setEndingSelection()| as primary function instead of wrapper.
-void EditCommand::setEndingSelection(const VisiblePosition& position) {
- if (position.isNull()) {
- setEndingSelection(SelectionInDOMTree());
- return;
- }
- setEndingSelection(SelectionInDOMTree::Builder()
- .collapse(position.toPositionWithAffinity())
- .build());
-}
-
bool EditCommand::isRenderedCharacter(const Position& position) {
if (position.isNull())
return false;

Powered by Google App Engine
This is Rietveld 408576698