third_party/WebKit/Source/core/editing/commands/InsertLineBreakCommand.cpp - Issue 2451093002: Get rid of EditCommand::setEndingSelection() taking one VisiblePosition

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/commands/InsertLineBreakCommand.cpp

Issue 2451093002: Get rid of EditCommand::setEndingSelection() taking one VisiblePosition (Closed)

Patch Set: 2016-10-26T16:39:39 Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/editing/commands/IndentOutdentCommand.cpp ('k') | third_party/WebKit/Source/core/editing/commands/InsertListCommand.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/commands/InsertLineBreakCommand.cpp

diff --git a/third_party/WebKit/Source/core/editing/commands/InsertLineBreakCommand.cpp b/third_party/WebKit/Source/core/editing/commands/InsertLineBreakCommand.cpp

index 13782f40fcfa1eb2c2ba1cf223e353a4b55691a7..2f347a9ef57456ed078d5b46e21f91ae98bad185 100644

--- a/third_party/WebKit/Source/core/editing/commands/InsertLineBreakCommand.cpp

+++ b/third_party/WebKit/Source/core/editing/commands/InsertLineBreakCommand.cpp

@@ -229,8 +229,9 @@ void InsertLineBreakCommand::doApply(EditingState* editingState) {

// So, this next call sets the endingSelection() to a caret just after the

// line break that we inserted, or just before it if it's at the end of a

// block.

- document().updateStyleAndLayoutIgnorePendingStylesheets();

- setEndingSelection(endingSelection().visibleEnd());

+ setEndingSelection(SelectionInDOMTree::Builder()

+ .collapse(endingSelection().end())

+ .build());

}

rebalanceWhitespace();