third_party/WebKit/Source/devtools/front_end/sdk/HeapProfilerModel.js - Issue 2450973002: [DevTools] Inherit WI.Target from Protocol.Target.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/sdk/HeapProfilerModel.js

Issue 2450973002: [DevTools] Inherit WI.Target from Protocol.Target. (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/components/NetworkConditionsSelector.js ('k') | third_party/WebKit/Source/devtools/front_end/sdk/InspectorBackend.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/sdk/HeapProfilerModel.js

diff --git a/third_party/WebKit/Source/devtools/front_end/sdk/HeapProfilerModel.js b/third_party/WebKit/Source/devtools/front_end/sdk/HeapProfilerModel.js

index 024052e45442d7351635754d8f63554ae5e1b74a..2f1b03fd9cd80968f907bf380ff12220d04e9b59 100644

--- a/third_party/WebKit/Source/devtools/front_end/sdk/HeapProfilerModel.js

+++ b/third_party/WebKit/Source/devtools/front_end/sdk/HeapProfilerModel.js

@@ -42,9 +42,7 @@ WebInspector.HeapProfilerModel.prototype = {

stopSampling: function()

{

this._isRecording = false;

- var currentProfile = null;

- return this._heapProfilerAgent.stopSampling((error, profile) => { currentProfile = !error ? profile : null; })

- .then(() => currentProfile);

+ return this._heapProfilerAgent.stopSampling((error, profile) => error ? null : profile);

/**