Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Unified Diff: third_party/WebKit/Source/devtools/front_end/sdk/Target.js

Issue 2450973002: [DevTools] Inherit WI.Target from Protocol.Target. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/sdk/Target.js
diff --git a/third_party/WebKit/Source/devtools/front_end/sdk/Target.js b/third_party/WebKit/Source/devtools/front_end/sdk/Target.js
index ab9bc8ed6629456f711999d003fbfaa2bed01914..26982edad0904dbed4f45eb9f833cfcafe7d477c 100644
--- a/third_party/WebKit/Source/devtools/front_end/sdk/Target.js
+++ b/third_party/WebKit/Source/devtools/front_end/sdk/Target.js
@@ -6,7 +6,7 @@
/**
* @constructor
- * @extends {Protocol.Agents}
+ * @extends {Protocol.Target}
* @param {!WebInspector.TargetManager} targetManager
* @param {string} name
* @param {number} capabilitiesMask
@@ -15,17 +15,13 @@
*/
WebInspector.Target = function(targetManager, name, capabilitiesMask, connectionFactory, parentTarget)
{
- // TODO(dgozman): inherit instead.
- var targetProto = new InspectorBackendClass.TargetPrototype(connectionFactory, this._dispose.bind(this));
- Protocol.Agents.call(this, targetProto.agentsMap());
+ Protocol.Target.call(this, connectionFactory);
this._targetManager = targetManager;
this._name = name;
this._inspectedURL = "";
this._capabilitiesMask = capabilitiesMask;
- this._targetProto = targetProto;
this._parentTarget = parentTarget;
this._id = WebInspector.Target._nextId++;
- this._disposed = false;
/** @type {!Map.<!Function, !WebInspector.SDKModel>} */
this._modelByConstructor = new Map();
@@ -103,16 +99,6 @@ WebInspector.Target.prototype = {
},
/**
- * @override
- * @param {string} domain
- * @param {!Object} dispatcher
- */
- registerDispatcher: function(domain, dispatcher)
- {
- this._targetProto.registerDispatcher(domain, dispatcher);
- },
-
- /**
* @return {boolean}
*/
hasBrowserCapability: function()
@@ -168,9 +154,11 @@ WebInspector.Target.prototype = {
return this._parentTarget;
},
- _dispose: function()
+ /**
+ * @override
+ */
+ dispose: function()
{
- this._disposed = true;
this._targetManager.removeTarget(this);
for (var model of this._modelByConstructor.valuesArray())
model.dispose();
@@ -179,14 +167,6 @@ WebInspector.Target.prototype = {
},
/**
- * @return {boolean}
- */
- isDisposed: function()
- {
- return this._disposed;
- },
-
- /**
* @param {!Function} modelClass
* @return {?WebInspector.SDKModel}
*/
@@ -226,7 +206,7 @@ WebInspector.Target.prototype = {
this._targetManager.dispatchEventToListeners(WebInspector.TargetManager.Events.NameChanged, this);
},
- __proto__: Protocol.Agents.prototype
+ __proto__: Protocol.Target.prototype
};
/**

Powered by Google App Engine
This is Rietveld 408576698