Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 2450183003: Fix some FX_BOOL / int noise in fxcrt. (Closed)

Created:
4 years, 1 month ago by Tom Sepez
Modified:
4 years, 1 month ago
Reviewers:
Lei Zhang, npm
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 6

Patch Set 2 : More bools everywhere #

Patch Set 3 : moar #

Patch Set 4 : win again #

Patch Set 5 : moar #

Unified diffs Side-by-side diffs Delta from patch set Stats (+339 lines, -317 lines) Patch
M core/fpdfapi/parser/cpdf_parser_unittest.cpp View 1 1 chunk +5 lines, -5 lines 0 comments Download
M core/fxcrt/extension.h View 1 2 5 chunks +15 lines, -18 lines 0 comments Download
M core/fxcrt/fx_basic_buffer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fxcrt/fx_extension.cpp View 1 2 11 chunks +38 lines, -38 lines 0 comments Download
M core/fxcrt/fx_stream.h View 1 5 chunks +22 lines, -22 lines 0 comments Download
M core/fxcrt/fx_xml_parser.cpp View 1 6 chunks +93 lines, -86 lines 0 comments Download
M core/fxcrt/fxcrt_posix.h View 1 2 2 chunks +5 lines, -5 lines 0 comments Download
M core/fxcrt/fxcrt_posix.cpp View 1 2 2 chunks +22 lines, -16 lines 0 comments Download
M core/fxcrt/fxcrt_stream.cpp View 1 2 chunks +3 lines, -3 lines 0 comments Download
M core/fxcrt/fxcrt_windows.h View 1 2 3 2 chunks +4 lines, -4 lines 0 comments Download
M core/fxcrt/fxcrt_windows.cpp View 1 2 3 5 chunks +59 lines, -42 lines 0 comments Download
M core/fxcrt/xml_int.h View 1 4 chunks +12 lines, -12 lines 0 comments Download
M fpdfsdk/fpdf_dataavail.cpp View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download
M fpdfsdk/fpdfsave.cpp View 1 2 chunks +8 lines, -8 lines 0 comments Download
M fpdfsdk/fpdfview.cpp View 1 2 3 5 chunks +28 lines, -28 lines 0 comments Download
M fpdfsdk/fsdk_define.h View 1 2 chunks +5 lines, -7 lines 0 comments Download
M xfa/fgas/crt/fgas_stream.h View 1 2 3 4 2 chunks +3 lines, -5 lines 0 comments Download
M xfa/fgas/crt/fgas_stream.cpp View 1 2 3 4 3 chunks +9 lines, -8 lines 0 comments Download
M xfa/fxfa/app/xfa_ffapp.cpp View 1 2 chunks +3 lines, -5 lines 0 comments Download
M xfa/fxfa/xfa_ffapp.h View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 28 (22 generated)
Tom Sepez
npm, next batch.
4 years, 1 month ago (2016-10-26 17:56:22 UTC) #2
npm
https://codereview.chromium.org/2450183003/diff/1/core/fxcrt/fx_basic_buffer.cpp File core/fxcrt/fx_basic_buffer.cpp (right): https://codereview.chromium.org/2450183003/diff/1/core/fxcrt/fx_basic_buffer.cpp#newcode247 core/fxcrt/fx_basic_buffer.cpp:247: return m_pFile->WriteBlock(m_pBuffer.get(), nRemaining); I think the compiler is complaining ...
4 years, 1 month ago (2016-10-26 18:26:04 UTC) #7
Tom Sepez
Ok, I think this does it. https://codereview.chromium.org/2450183003/diff/1/core/fxcrt/fx_basic_buffer.cpp File core/fxcrt/fx_basic_buffer.cpp (right): https://codereview.chromium.org/2450183003/diff/1/core/fxcrt/fx_basic_buffer.cpp#newcode247 core/fxcrt/fx_basic_buffer.cpp:247: return m_pFile->WriteBlock(m_pBuffer.get(), nRemaining); ...
4 years, 1 month ago (2016-10-26 20:47:03 UTC) #20
npm
lgtm
4 years, 1 month ago (2016-10-26 22:29:37 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2450183003/80001
4 years, 1 month ago (2016-10-26 22:33:42 UTC) #26
commit-bot: I haz the power
4 years, 1 month ago (2016-10-26 22:34:06 UTC) #28
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://pdfium.googlesource.com/pdfium/+/f39074c0ae47a84c496782f8b75bcce1e1cf...

Powered by Google App Engine
This is Rietveld 408576698