Fix some FX_BOOL / int noise in fxcrt.

Fix some FX_BOOL / int noise in fxcrt.

Committed: https://pdfium.googlesource.com/pdfium/+/f39074c0ae47a84c496782f8b75bcce1e1cfdf59

[Tom Sepez, 2016-10-26 17:56:22]

tsepez@chromium.org changed reviewers:
+ npm@chromium.org

[Tom Sepez, 2016-10-26 17:56:22]

npm, next batch.

[Tom Sepez, 2016-10-26 17:56:51]

The CQ bit was checked by tsepez@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-26 17:56:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-26 18:01:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-26 18:01:59]

Dry run: Try jobs failed on following builders:
  win_no_v8 on master.tryserver.client.pdfium (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.pdfium/builders/win_no_v8/build...)

[npm, 2016-10-26 18:26:04]

https://codereview.chromium.org/2450183003/diff/1/core/fxcrt/fx_basic_buffer.cpp
File core/fxcrt/fx_basic_buffer.cpp (right):

https://codereview.chromium.org/2450183003/diff/1/core/fxcrt/fx_basic_buffer....
core/fxcrt/fx_basic_buffer.cpp:247: return m_pFile->WriteBlock(m_pBuffer.get(),
nRemaining);
I think the compiler is complaining about this

https://codereview.chromium.org/2450183003/diff/1/core/fxcrt/fx_extension.cpp
File core/fxcrt/fx_extension.cpp (right):

https://codereview.chromium.org/2450183003/diff/1/core/fxcrt/fx_extension.cpp...
core/fxcrt/fx_extension.cpp:321: return m_pFile->WritePos(buffer, size, offset)
== size;
Is WritePos guaranteed to return either 0 or size?

https://codereview.chromium.org/2450183003/diff/1/core/fxcrt/fx_xml_parser.cpp
File core/fxcrt/fx_xml_parser.cpp (right):

https://codereview.chromium.org/2450183003/diff/1/core/fxcrt/fx_xml_parser.cp...
core/fxcrt/fx_xml_parser.cpp:18: #define FXCRTM_XML_CHARTYPE_Normal 0x00
Some of these appear to be unused. Remove them

[Tom Sepez, 2016-10-26 19:26:52]

The CQ bit was checked by tsepez@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-26 19:26:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-26 19:32:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-26 19:32:26]

Dry run: Try jobs failed on following builders:
  win_xfa on master.tryserver.client.pdfium (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.pdfium/builders/win_xfa/builds/...)

[Tom Sepez, 2016-10-26 20:15:40]

The CQ bit was checked by tsepez@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-26 20:15:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-26 20:20:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-26 20:20:35]

Dry run: Try jobs failed on following builders:
  win on master.tryserver.client.pdfium (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.pdfium/builders/win/builds/2585)
  win_no_v8 on master.tryserver.client.pdfium (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.pdfium/builders/win_no_v8/build...)

[Tom Sepez, 2016-10-26 20:32:34]

The CQ bit was checked by tsepez@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-26 20:32:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Tom Sepez, 2016-10-26 20:36:40]

The CQ bit was checked by tsepez@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-26 20:36:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Tom Sepez, 2016-10-26 20:47:03]

Ok, I think this does it.

https://codereview.chromium.org/2450183003/diff/1/core/fxcrt/fx_basic_buffer.cpp
File core/fxcrt/fx_basic_buffer.cpp (right):

https://codereview.chromium.org/2450183003/diff/1/core/fxcrt/fx_basic_buffer....
core/fxcrt/fx_basic_buffer.cpp:247: return m_pFile->WriteBlock(m_pBuffer.get(),
nRemaining);
On 2016/10/26 18:26:04, npm wrote:
> I think the compiler is complaining about this

Acknowledged.  I'll make all of these ordinary bools.

https://codereview.chromium.org/2450183003/diff/1/core/fxcrt/fx_extension.cpp
File core/fxcrt/fx_extension.cpp (right):

https://codereview.chromium.org/2450183003/diff/1/core/fxcrt/fx_extension.cpp...
core/fxcrt/fx_extension.cpp:321: return m_pFile->WritePos(buffer, size, offset)
== size;
On 2016/10/26 18:26:04, npm wrote:
> Is WritePos guaranteed to return either 0 or size?

reverted to old behaviour via !!

https://codereview.chromium.org/2450183003/diff/1/core/fxcrt/fx_xml_parser.cpp
File core/fxcrt/fx_xml_parser.cpp (right):

https://codereview.chromium.org/2450183003/diff/1/core/fxcrt/fx_xml_parser.cp...
core/fxcrt/fx_xml_parser.cpp:18: #define FXCRTM_XML_CHARTYPE_Normal 0x00
On 2016/10/26 18:26:04, npm wrote:
> Some of these appear to be unused. Remove them

Yes, but they document what the bits are in the bytetypes table below.  If I
were to pull them, I'd have to go through and update all the values below to not
use them either.

[commit-bot: I haz the power, 2016-10-26 21:01:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-26 21:01:21]

Dry run: This issue passed the CQ dry run.

[Tom Sepez, 2016-10-26 21:31:47]

tsepez@chromium.org changed reviewers:
+ thestig@chromium.org

[npm, 2016-10-26 22:29:37]

lgtm

[Tom Sepez, 2016-10-26 22:33:40]

The CQ bit was checked by tsepez@chromium.org

[commit-bot: I haz the power, 2016-10-26 22:33:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-26 22:34:00]

Description was changed from

==========
Fix some FX_BOOL / int noise in fxcrt.
==========

to

==========
Fix some FX_BOOL / int noise in fxcrt.

Committed:
https://pdfium.googlesource.com/pdfium/+/f39074c0ae47a84c496782f8b75bcce1e1cf...
==========

[commit-bot: I haz the power, 2016-10-26 22:34:06]

Committed patchset #5 (id:80001) as
https://pdfium.googlesource.com/pdfium/+/f39074c0ae47a84c496782f8b75bcce1e1cf...