Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(304)

Side by Side Diff: core/fpdfapi/parser/cpdf_parser_unittest.cpp

Issue 2450183003: Fix some FX_BOOL / int noise in fxcrt. (Closed)
Patch Set: moar Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | core/fxcrt/extension.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 PDFium Authors. All rights reserved. 1 // Copyright 2015 PDFium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <limits> 5 #include <limits>
6 #include <string> 6 #include <string>
7 7
8 #include "core/fpdfapi/parser/cpdf_parser.h" 8 #include "core/fpdfapi/parser/cpdf_parser.h"
9 #include "core/fpdfapi/parser/cpdf_syntax_parser.h" 9 #include "core/fpdfapi/parser/cpdf_syntax_parser.h"
10 #include "core/fxcrt/fx_ext.h" 10 #include "core/fxcrt/fx_ext.h"
11 #include "core/fxcrt/fx_stream.h" 11 #include "core/fxcrt/fx_stream.h"
12 #include "testing/gtest/include/gtest/gtest.h" 12 #include "testing/gtest/include/gtest/gtest.h"
13 #include "testing/utils/path_service.h" 13 #include "testing/utils/path_service.h"
14 14
15 // Provide a way to read test data from a buffer instead of a file. 15 // Provide a way to read test data from a buffer instead of a file.
16 class CFX_TestBufferRead : public IFX_SeekableReadStream { 16 class CFX_TestBufferRead : public IFX_SeekableReadStream {
17 public: 17 public:
18 CFX_TestBufferRead(const unsigned char* buffer_in, size_t buf_size) 18 CFX_TestBufferRead(const unsigned char* buffer_in, size_t buf_size)
19 : buffer_(buffer_in), total_size_(buf_size) {} 19 : buffer_(buffer_in), total_size_(buf_size) {}
20 20
21 // IFX_Stream 21 // IFX_Stream
22 void Release() override { delete this; } 22 void Release() override { delete this; }
23 23
24 // IFX_SeekableReadStream 24 // IFX_SeekableReadStream
25 FX_BOOL ReadBlock(void* buffer, FX_FILESIZE offset, size_t size) override { 25 bool ReadBlock(void* buffer, FX_FILESIZE offset, size_t size) override {
26 if (offset < 0 || offset + size > total_size_) { 26 if (offset < 0 || offset + size > total_size_)
27 return FALSE; 27 return false;
28 }
29 28
30 memcpy(buffer, buffer_ + offset, size); 29 memcpy(buffer, buffer_ + offset, size);
31 return TRUE; 30 return true;
32 } 31 }
32
33 FX_FILESIZE GetSize() override { return (FX_FILESIZE)total_size_; }; 33 FX_FILESIZE GetSize() override { return (FX_FILESIZE)total_size_; };
34 34
35 protected: 35 protected:
36 const unsigned char* buffer_; 36 const unsigned char* buffer_;
37 size_t total_size_; 37 size_t total_size_;
38 }; 38 };
39 39
40 // A wrapper class to help test member functions of CPDF_Parser. 40 // A wrapper class to help test member functions of CPDF_Parser.
41 class CPDF_TestParser : public CPDF_Parser { 41 class CPDF_TestParser : public CPDF_Parser {
42 public: 42 public:
(...skipping 150 matching lines...) Expand 10 before | Expand all | Expand 10 after
193 193
194 ASSERT_TRUE(parser.LoadCrossRefV4(0, 0, FALSE)); 194 ASSERT_TRUE(parser.LoadCrossRefV4(0, 0, FALSE));
195 const FX_FILESIZE offsets[] = {0, 23, 0, 0, 0, 45, 179}; 195 const FX_FILESIZE offsets[] = {0, 23, 0, 0, 0, 45, 179};
196 const uint8_t types[] = {0, 1, 0, 0, 0, 1, 1}; 196 const uint8_t types[] = {0, 1, 0, 0, 0, 1, 1};
197 for (size_t i = 0; i < FX_ArraySize(offsets); ++i) { 197 for (size_t i = 0; i < FX_ArraySize(offsets); ++i) {
198 EXPECT_EQ(offsets[i], parser.m_ObjectInfo[i].pos); 198 EXPECT_EQ(offsets[i], parser.m_ObjectInfo[i].pos);
199 EXPECT_EQ(types[i], parser.m_ObjectInfo[i].type); 199 EXPECT_EQ(types[i], parser.m_ObjectInfo[i].type);
200 } 200 }
201 } 201 }
202 } 202 }
OLDNEW
« no previous file with comments | « no previous file | core/fxcrt/extension.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698