Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1062)

Unified Diff: core/fxcrt/xml_int.h

Issue 2450183003: Fix some FX_BOOL / int noise in fxcrt. (Closed)
Patch Set: moar Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « core/fxcrt/fxcrt_windows.cpp ('k') | fpdfsdk/fpdf_dataavail.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: core/fxcrt/xml_int.h
diff --git a/core/fxcrt/xml_int.h b/core/fxcrt/xml_int.h
index aa157c23333218eeab300c96f3ec003250679a11..bc9ea3dd48e6566c994ae3d3e82ba48d62becd80 100644
--- a/core/fxcrt/xml_int.h
+++ b/core/fxcrt/xml_int.h
@@ -21,10 +21,10 @@ class CXML_DataBufAcc : public IFX_BufferRead {
// IFX_BufferRead
void Release() override;
- FX_BOOL IsEOF() override;
+ bool IsEOF() override;
FX_FILESIZE GetPosition() override;
size_t ReadBlock(void* buffer, size_t size) override;
- FX_BOOL ReadNextBlock(FX_BOOL bRestart = FALSE) override;
+ bool ReadNextBlock(bool bRestart = FALSE) override;
const uint8_t* GetBlockBuffer() override;
size_t GetBlockSize() override;
FX_FILESIZE GetBlockOffset() override;
@@ -42,10 +42,10 @@ class CXML_DataStmAcc : public IFX_BufferRead {
// IFX_BufferRead
void Release() override;
- FX_BOOL IsEOF() override;
+ bool IsEOF() override;
FX_FILESIZE GetPosition() override;
size_t ReadBlock(void* buffer, size_t size) override;
- FX_BOOL ReadNextBlock(FX_BOOL bRestart = FALSE) override;
+ bool ReadNextBlock(bool bRestart = FALSE) override;
const uint8_t* GetBlockBuffer() override;
size_t GetBlockSize() override;
FX_FILESIZE GetBlockOffset() override;
@@ -62,13 +62,13 @@ class CXML_Parser {
CXML_Parser();
~CXML_Parser();
- FX_BOOL Init(uint8_t* pBuffer, size_t size);
- FX_BOOL Init(IFX_SeekableReadStream* pFileRead);
- FX_BOOL Init(IFX_BufferRead* pBuffer);
- FX_BOOL Init(FX_BOOL bOwndedStream);
- FX_BOOL ReadNextBlock();
- FX_BOOL IsEOF();
- FX_BOOL HaveAvailData();
+ bool Init(uint8_t* pBuffer, size_t size);
+ bool Init(IFX_SeekableReadStream* pFileRead);
+ bool Init(IFX_BufferRead* pBuffer);
+ bool Init(bool bOwndedStream);
+ bool ReadNextBlock();
+ bool IsEOF();
+ bool HaveAvailData();
void SkipWhiteSpaces();
void GetName(CFX_ByteString& space, CFX_ByteString& name);
void GetAttrValue(CFX_WideString& value);
@@ -85,7 +85,7 @@ class CXML_Parser {
void InsertCDATASegment(CFX_UTF8Decoder& decoder, CXML_Element* pElement);
IFX_BufferRead* m_pDataAcc;
- FX_BOOL m_bOwnedStream;
+ bool m_bOwnedStream;
FX_FILESIZE m_nOffset;
FX_BOOL m_bSaveSpaceChars;
const uint8_t* m_pBuffer;
« no previous file with comments | « core/fxcrt/fxcrt_windows.cpp ('k') | fpdfsdk/fpdf_dataavail.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698