Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Side by Side Diff: core/fxcrt/fx_basic_buffer.cpp

Issue 2450183003: Fix some FX_BOOL / int noise in fxcrt. (Closed)
Patch Set: moar Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « core/fxcrt/extension.h ('k') | core/fxcrt/fx_extension.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 PDFium Authors. All rights reserved. 1 // Copyright 2014 PDFium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com 5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <limits> 8 #include <limits>
9 9
10 #include "core/fxcrt/fx_basic.h" 10 #include "core/fxcrt/fx_basic.h"
(...skipping 226 matching lines...) Expand 10 before | Expand all | Expand 10 after
237 m_pFile = nullptr; 237 m_pFile = nullptr;
238 } 238 }
239 239
240 bool CFX_FileBufferArchive::Flush() { 240 bool CFX_FileBufferArchive::Flush() {
241 size_t nRemaining = m_Length; 241 size_t nRemaining = m_Length;
242 m_Length = 0; 242 m_Length = 0;
243 if (!m_pFile) 243 if (!m_pFile)
244 return false; 244 return false;
245 if (!m_pBuffer || !nRemaining) 245 if (!m_pBuffer || !nRemaining)
246 return true; 246 return true;
247 return m_pFile->WriteBlock(m_pBuffer.get(), nRemaining) > 0; 247 return m_pFile->WriteBlock(m_pBuffer.get(), nRemaining);
248 } 248 }
249 249
250 int32_t CFX_FileBufferArchive::AppendBlock(const void* pBuf, size_t size) { 250 int32_t CFX_FileBufferArchive::AppendBlock(const void* pBuf, size_t size) {
251 if (!pBuf || size < 1) 251 if (!pBuf || size < 1)
252 return 0; 252 return 0;
253 253
254 if (!m_pBuffer) 254 if (!m_pBuffer)
255 m_pBuffer.reset(FX_Alloc(uint8_t, kBufSize)); 255 m_pBuffer.reset(FX_Alloc(uint8_t, kBufSize));
256 256
257 const uint8_t* buffer = reinterpret_cast<const uint8_t*>(pBuf); 257 const uint8_t* buffer = reinterpret_cast<const uint8_t*>(pBuf);
(...skipping 24 matching lines...) Expand all
282 } 282 }
283 283
284 int32_t CFX_FileBufferArchive::AppendString(const CFX_ByteStringC& lpsz) { 284 int32_t CFX_FileBufferArchive::AppendString(const CFX_ByteStringC& lpsz) {
285 return AppendBlock(lpsz.raw_str(), lpsz.GetLength()); 285 return AppendBlock(lpsz.raw_str(), lpsz.GetLength());
286 } 286 }
287 287
288 void CFX_FileBufferArchive::AttachFile(IFX_WriteStream* pFile) { 288 void CFX_FileBufferArchive::AttachFile(IFX_WriteStream* pFile) {
289 ASSERT(pFile); 289 ASSERT(pFile);
290 m_pFile = pFile; 290 m_pFile = pFile;
291 } 291 }
OLDNEW
« no previous file with comments | « core/fxcrt/extension.h ('k') | core/fxcrt/fx_extension.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698