Fix some FX_BOOL / int noise in fxcrt.

core/fxcrt/fx_extension.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include <utility>
 
 #include "core/fxcrt/extension.h"
 #include "core/fxcrt/fx_basic.h"
@@ skipping 290 matching lines @@
   return GetPosition() >= GetSize();
 }
 
 FX_FILESIZE CFX_CRTFileStream::GetPosition() {
   return m_pFile->GetPosition();
 }
 
 FX_BOOL CFX_CRTFileStream::ReadBlock(void* buffer,
                                      FX_FILESIZE offset,
                                      size_t size) {
-  return (FX_BOOL)m_pFile->ReadPos(buffer, size, offset);
+  return m_pFile->ReadPos(buffer, size, offset) > 0;
 }
 
 size_t CFX_CRTFileStream::ReadBlock(void* buffer, size_t size) {
   return m_pFile->Read(buffer, size);
 }
 
 FX_BOOL CFX_CRTFileStream::WriteBlock(const void* buffer,
                                       FX_FILESIZE offset,
                                       size_t size) {
-  return (FX_BOOL)m_pFile->WritePos(buffer, size, offset);
+  return m_pFile->WritePos(buffer, size, offset) == size;

[npm, 2016/10/26 18:26:04]

Is WritePos guaranteed to return either 0 or size?

[Tom Sepez, 2016/10/26 20:47:03]

reverted to old behaviour via !!

 }
 
 FX_BOOL CFX_CRTFileStream::Flush() {
   return m_pFile->Flush();
 }
 
 #ifdef PDF_ENABLE_XFA
 IFX_FileAccess* FX_CreateDefaultFileAccess(const CFX_WideStringC& wsPath) {
   if (wsPath.GetLength() == 0)
     return nullptr;
@@ skipping 278 matching lines @@
     b = ((const uint8_t*)pGUID)[i];
     *pBuf++ = gs_FX_pHexChars[b >> 4];
     *pBuf++ = gs_FX_pHexChars[b & 0x0F];
     if (bSeparator && (i == 3 || i == 5 || i == 7 || i == 9)) {
       *pBuf++ = L'-';
     }
   }
   bsStr.ReleaseBuffer(bSeparator ? 36 : 32);
 }
 #endif  // PDF_ENABLE_XFA