bluetooth: Require frame to be connected for writValue to succeed.

bluetooth: Require frame to be connected for writValue to succeed.

If frame is not connected or disconnects during a writeValue request we
reject the writeValue promise with NetworkError.

BUG=608538
Committed: https://crrev.com/d7ea1be86b592dbbfa1fe83bfcc5709a1b526b42
Cr-Commit-Position: refs/heads/master@{#428637}

[ortuno, 2016-10-24 02:08:24]

The CQ bit was checked by ortuno@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-24 02:08:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-24 03:40:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-24 03:40:12]

Dry run: This issue passed the CQ dry run.

[ortuno, 2016-10-24 04:12:03]

ortuno@chromium.org changed reviewers:
+ jyasskin@chromium.org

[ortuno, 2016-10-24 04:12:04]

jyasskin: PTAL

[ortuno, 2016-10-24 05:30:54]

ortuno@chromium.org changed reviewers:
+ scheib@chromium.org
- jyasskin@chromium.org

[ortuno, 2016-10-24 05:30:54]

scheib: PTAL

[scheib, 2016-10-24 23:58:14]

Sorry, still in progress, some previous code feedback.

https://codereview.chromium.org/2445633002/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/bluetooth/script-tests/gatt-op-device-disconnects-before.js
(right):

https://codereview.chromium.org/2445633002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/bluetooth/script-tests/gatt-op-device-disconnects-before.js:1:
'use strict';
First time seeing generated files. What is this 'CALLS' thing? Takes a bit in
code search to find the info in generate.py. Where did I look first? Top of file
-- a good place to indicate something as it's easy to find in code reviews.
Also, script-tests/README. Also, at least to me it's odd to have generate.py not
be in script-tests dir.

When reading generate.py: 

PREVIOUS_CALL, FUNCTION_NAME, don't appear in the examples in file. I suppose
OK. CALL_PREVIOUS_FUNCTION and PREVIOUS_FUNCTION_NAME, may have been more clear?

I don't know what '-with-uuid' means

[ortuno, 2016-10-25 01:56:06]

https://codereview.chromium.org/2445633002/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/bluetooth/script-tests/gatt-op-device-disconnects-before.js
(right):

https://codereview.chromium.org/2445633002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/bluetooth/script-tests/gatt-op-device-disconnects-before.js:1:
'use strict';
On 2016/10/24 at 23:58:14, scheib wrote:
> First time seeing generated files. What is this 'CALLS' thing? Takes a bit in
code search to find the info in generate.py. Where did I look first? Top of file
-- a good place to indicate something as it's easy to find in code reviews.
Also, script-tests/README. Also, at least to me it's odd to have generate.py not
be in script-tests dir.
> 

I followed the same pattern as fetch. I can change if you feel strongly about
it, though I think it would be weird for a script to touch directories in its
parent's parent.

https://cs.chromium.org/chromium/src/third_party/WebKit/LayoutTests/http/test...

> When reading generate.py: 
> 
> PREVIOUS_CALL, FUNCTION_NAME, don't appear in the examples in file. I suppose
OK.

Hmm I might be missing something but they are included in the example:

PREVIOUS_CALL:
https://cs.chromium.org/chromium/src/third_party/WebKit/LayoutTests/bluetooth...

FUNCTION_NAME:
https://cs.chromium.org/chromium/src/third_party/WebKit/LayoutTests/bluetooth...

> CALL_PREVIOUS_FUNCTION and PREVIOUS_FUNCTION_NAME, may have been more clear?
> 
> I don't know what '-with-uuid' means

It's just a suffix to distinguish between getPrimaryServices() and
getPrimaryServices(uuid) tests.

I can send out a follow up patch to address these issues.

[ortuno, 2016-10-26 22:45:42]

ping?

[scheib, 2016-10-28 21:18:24]

LGTM

[ortuno, 2016-10-30 21:47:19]

The CQ bit was checked by ortuno@chromium.org

[commit-bot: I haz the power, 2016-10-30 21:47:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-31 00:42:33]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-31 00:44:37]

Description was changed from

==========
bluetooth: Require frame to be connected for writValue to succeed.

If frame is not connected or disconnects during a writeValue request we
reject the writeValue promise with NetworkError.

BUG=608538
==========

to

==========
bluetooth: Require frame to be connected for writValue to succeed.

If frame is not connected or disconnects during a writeValue request we
reject the writeValue promise with NetworkError.

BUG=608538

Committed: https://crrev.com/d7ea1be86b592dbbfa1fe83bfcc5709a1b526b42
Cr-Commit-Position: refs/heads/master@{#428637}
==========

[commit-bot: I haz the power, 2016-10-31 00:44:38]

Patchset 2 (id:??) landed as
https://crrev.com/d7ea1be86b592dbbfa1fe83bfcc5709a1b526b42
Cr-Commit-Position: refs/heads/master@{#428637}