Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2207)

Unified Diff: content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.h

Issue 2445633002: bluetooth: Require frame to be connected for writValue to succeed. (Closed)
Patch Set: Fix documentation Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.h
diff --git a/content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.h b/content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.h
index 20536a5e8f62263302c2fa5d69722e5e1348a9a8..0069714f6087f3b43def661263ad26bb3cd835b2 100644
--- a/content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.h
+++ b/content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.h
@@ -316,6 +316,7 @@ class LayoutTestBluetoothAdapterProvider {
// - Measurement Interval (0x2a21):
// - Read: Calls GattCharacteristicValueChanged and success
// callback with [1].
+ // - Write: Calls success callback.
// - GetProperties: Returns
// BluetoothRemoteGattCharacteristic::PROPERTY_READ
// TODO(crbug.com/608538): Mock Write and StartNotifySession.
@@ -361,6 +362,10 @@ class LayoutTestBluetoothAdapterProvider {
// otherwise it saves a failing callback. This callback
// is run during CreateGattConnection. If |disconnect| is true
// disconnects the device.
+ // - Write: If |succeeds| is true, saves a succeeding callback,
+ // otherwise it saves a failing callback. This callback is run
+ // during CreateGattConnection. If |disconnect| is true
+ // disconnects the device.
// - CreateGattConnection: Runs success callback with a new GATT
// connection and runs any pending GATT operation callbacks.
static scoped_refptr<testing::NiceMock<device::MockBluetoothAdapter>>

Powered by Google App Engine
This is Rietveld 408576698