Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(644)

Issue 2447593002: bluetooth: Require frame to be connected for startNotifications to succeed. (Closed)

Created:
4 years, 2 months ago by ortuno
Modified:
4 years, 1 month ago
Reviewers:
scheib
CC:
blink-reviews, chromium-reviews, darin-cc_chromium.org, einbinder+watch-test-runner_chromium.org, haraken, jam, jochen+watch_chromium.org, mlamouri+watch-content_chromium.org, mlamouri+watch-test-runner_chromium.org, ortuno+watch_chromium.org, Peter Beverloo, scheib+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

bluetooth: Require frame to be connected for startNotifications to succeed. If a frame is not connected or disconnects during a startNotifications request we reject the startNotifications promise with NetworkError. BUG=608538 Committed: https://crrev.com/875f017e58543a5fa0f03e56478d86072bf26bc2 Cr-Commit-Position: refs/heads/master@{#428651}

Patch Set 1 #

Patch Set 2 : Remove stopNotifications code #

Unified diffs Side-by-side diffs Delta from patch set Stats (+125 lines, -38 lines) Patch
M content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.h View 1 2 chunks +5 lines, -1 line 0 comments Download
M content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.cc View 1 4 chunks +36 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/script-tests/gatt-op-device-disconnects-before.js View 1 1 chunk +4 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/script-tests/gatt-op-device-disconnects-during-error.js View 1 1 chunk +4 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/script-tests/gatt-op-device-disconnects-during-success.js View 1 1 chunk +4 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/script-tests/gatt-op-device-reconnects-during-error.js View 1 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/script-tests/gatt-op-device-reconnects-during-success.js View 1 1 chunk +4 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/script-tests/gatt-op-disconnect-called-before.js View 1 1 chunk +4 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/script-tests/gatt-op-disconnect-called-during-error.js View 1 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/script-tests/gatt-op-disconnect-called-during-success.js View 1 1 chunk +4 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/script-tests/gatt-op-reconnect-during-error.js View 1 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/script-tests/gatt-op-reconnect-during-success.js View 1 1 chunk +4 lines, -1 line 0 comments Download
A + third_party/WebKit/LayoutTests/bluetooth/startNotifications/gen-gatt-op-device-disconnects-before.html View 1 chunk +2 lines, -2 lines 0 comments Download
A + third_party/WebKit/LayoutTests/bluetooth/startNotifications/gen-gatt-op-device-disconnects-during-error.html View 1 1 chunk +2 lines, -2 lines 0 comments Download
A + third_party/WebKit/LayoutTests/bluetooth/startNotifications/gen-gatt-op-device-disconnects-during-success.html View 1 chunk +2 lines, -2 lines 0 comments Download
A + third_party/WebKit/LayoutTests/bluetooth/startNotifications/gen-gatt-op-device-reconnects-during-error.html View 1 1 chunk +2 lines, -2 lines 0 comments Download
A + third_party/WebKit/LayoutTests/bluetooth/startNotifications/gen-gatt-op-device-reconnects-during-success.html View 1 1 chunk +2 lines, -2 lines 0 comments Download
A + third_party/WebKit/LayoutTests/bluetooth/startNotifications/gen-gatt-op-disconnect-called-before.html View 1 chunk +2 lines, -2 lines 0 comments Download
A + third_party/WebKit/LayoutTests/bluetooth/startNotifications/gen-gatt-op-disconnect-called-during-error.html View 1 2 chunks +2 lines, -2 lines 0 comments Download
A + third_party/WebKit/LayoutTests/bluetooth/startNotifications/gen-gatt-op-disconnect-called-during-success.html View 2 chunks +2 lines, -2 lines 0 comments Download
A + third_party/WebKit/LayoutTests/bluetooth/startNotifications/gen-gatt-op-reconnect-during-error.html View 1 1 chunk +2 lines, -2 lines 0 comments Download
A + third_party/WebKit/LayoutTests/bluetooth/startNotifications/gen-gatt-op-reconnect-during-success.html View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTCharacteristic.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTCharacteristic.cpp View 1 2 chunks +29 lines, -3 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 12 (7 generated)
ortuno
scheib: PTAL
4 years, 2 months ago (2016-10-24 05:31:21 UTC) #6
scheib
LGTM
4 years, 1 month ago (2016-10-28 20:10:52 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2447593002/20001
4 years, 1 month ago (2016-10-31 02:20:00 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-10-31 03:46:50 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-10-31 03:49:59 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/875f017e58543a5fa0f03e56478d86072bf26bc2
Cr-Commit-Position: refs/heads/master@{#428651}

Powered by Google App Engine
This is Rietveld 408576698