Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(348)

Unified Diff: third_party/WebKit/LayoutTests/resources/bluetooth/bluetooth-helpers.js

Issue 2445633002: bluetooth: Require frame to be connected for writValue to succeed. (Closed)
Patch Set: Fix documentation Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/resources/bluetooth/bluetooth-helpers.js
diff --git a/third_party/WebKit/LayoutTests/resources/bluetooth/bluetooth-helpers.js b/third_party/WebKit/LayoutTests/resources/bluetooth/bluetooth-helpers.js
index 25cd7911ae71e0cd5361909ffb104661d0179ba3..a8e4f8940a6cb0e9a05547eb5876e03341647e9a 100644
--- a/third_party/WebKit/LayoutTests/resources/bluetooth/bluetooth-helpers.js
+++ b/third_party/WebKit/LayoutTests/resources/bluetooth/bluetooth-helpers.js
@@ -324,9 +324,11 @@ function get_request_disconnection(gattServer) {
return gattServer.getPrimaryService(request_disconnection_service_uuid)
.then(service => service.getCharacteristic(request_disconnection_characteristic_uuid))
.then(characteristic => {
- // TODO(crbug.com/543466): Wrap in assert_promise_rejects_with_message()
- // once connection is required for writeValue to succeed.
- return () => characteristic.writeValue(new Uint8Array([0]));
+ return () => assert_promise_rejects_with_message(
+ characteristic.writeValue(new Uint8Array([0])),
+ new DOMException(
+ 'GATT Server disconnected while performing a GATT operation.',
+ 'NetworkError'));
});
}

Powered by Google App Engine
This is Rietveld 408576698