bluetooth: Introduce helper function for requesting a disconnection

bluetooth: Introduce helper function for requesting a disconnection

Introduces a new helper function that will contain
"requestDisconnection.writeValue(...)" wrapped inside a
assert_promise_rejects_with_message.

We need to wrap the disconnection request because writeValue will soon
require a frame to be connected for operations to succeed.

BUG=608538
Committed: https://crrev.com/f97d6a29e488d8a57764e1a45c054ef3dc2d421e
Cr-Commit-Position: refs/heads/master@{#427594}

[ortuno, 2016-10-24 05:31:45]

The CQ bit was checked by ortuno@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-24 05:31:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-24 06:34:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-24 06:34:14]

Dry run: This issue passed the CQ dry run.

[ortuno, 2016-10-24 21:26:38]

ortuno@chromium.org changed reviewers:
+ scheib@chromium.org

[ortuno, 2016-10-24 21:26:39]

scheib: PTAL

[scheib, 2016-10-25 04:28:05]

LGTM with suggestion for helper comment

https://codereview.chromium.org/2441313002/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/resources/bluetooth/bluetooth-helpers.js
(right):

https://codereview.chromium.org/2441313002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/resources/bluetooth/bluetooth-helpers.js:321: //
Returns a function that when called returns a promise that resolves when
Returns via a promise a function 'request_disconnection()',
which via a promise resolves when the device has disconnected.
Use by:
  device.gatt.connect()
  .then(gattServer => get_request_disconnection(gattServer))
  .then(requestDisconnection => requestDisconnection())
  .then(() => // device has disconnected ...

[ortuno, 2016-10-26 04:03:21]

The CQ bit was checked by ortuno@chromium.org

[ortuno, 2016-10-26 04:03:22]

Thanks!

https://codereview.chromium.org/2441313002/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/resources/bluetooth/bluetooth-helpers.js
(right):

https://codereview.chromium.org/2441313002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/resources/bluetooth/bluetooth-helpers.js:321: //
Returns a function that when called returns a promise that resolves when
On 2016/10/25 at 04:28:05, scheib wrote:
> Returns via a promise a function 'request_disconnection()',
> which via a promise resolves when the device has disconnected.
> Use by:
>   device.gatt.connect()
>   .then(gattServer => get_request_disconnection(gattServer))
>   .then(requestDisconnection => requestDisconnection())
>   .then(() => // device has disconnected ...

Done.

[ortuno, 2016-10-26 04:03:22]

The patchset sent to the CQ was uploaded after l-g-t-m from scheib@chromium.org
Link to the patchset: https://codereview.chromium.org/2441313002/#ps40001
(title: "Add example to function")

[commit-bot: I haz the power, 2016-10-26 04:04:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-26 05:03:54]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-10-26 05:05:45]

Description was changed from

==========
bluetooth: Introduce helper function for requesting a disconnection

Introduces a new helper function that will contain
"requestDisconnection.writeValue(...)" wrapped inside a
assert_promise_rejects_with_message.

We need to wrap the disconnection request because writeValue will soon
require a frame to be connected for operations to succeed.

BUG=608538
==========

to

==========
bluetooth: Introduce helper function for requesting a disconnection

Introduces a new helper function that will contain
"requestDisconnection.writeValue(...)" wrapped inside a
assert_promise_rejects_with_message.

We need to wrap the disconnection request because writeValue will soon
require a frame to be connected for operations to succeed.

BUG=608538

Committed: https://crrev.com/f97d6a29e488d8a57764e1a45c054ef3dc2d421e
Cr-Commit-Position: refs/heads/master@{#427594}
==========

[commit-bot: I haz the power, 2016-10-26 05:05:46]

Patchset 3 (id:??) landed as
https://crrev.com/f97d6a29e488d8a57764e1a45c054ef3dc2d421e
Cr-Commit-Position: refs/heads/master@{#427594}