Make the virtual keyboard show up on the display with input focus.

Let the virtual keyboard show up on the secondary screen.

This CL let the virtual keyboard show up on a display if
1. the display has touch capability and the input focus goes to
   a window in that display.
2. the keyboard icon in the tray in that display is pressed.

BUG=303429
TEST=Connect the secondary display. Verify that the virtual
     keyboard or the accessibility on-screen keyboard follows
     the input focus if the focused window is in the display
     which has touch capability.
TEST=Added unit tests in root_window_controller_unittest.cc

Committed: https://crrev.com/7e20c9b1abf3784127b729a7fcd820e11a78afc9
Cr-Commit-Position: refs/heads/master@{#434409}

[yhanada, 2016-10-25 06:30:26]

The CQ bit was checked by yhanada@chromium.org

[yhanada, 2016-10-25 06:30:31]

The CQ bit was unchecked by yhanada@chromium.org

[yhanada, 2016-10-25 06:30:39]

The CQ bit was checked by yhanada@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-25 06:30:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-25 07:04:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-25 07:04:26]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[yhanada, 2016-10-25 11:32:15]

The CQ bit was checked by yhanada@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-25 11:32:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-25 11:48:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-25 11:48:22]

Dry run: Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[yhanada, 2016-10-26 11:23:15]

The CQ bit was checked by yhanada@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-26 11:23:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-26 11:47:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-26 11:47:21]

Dry run: This issue passed the CQ dry run.

[yhanada, 2016-10-26 12:12:09]

yhanada@chromium.org changed reviewers:
+ oshima@chromium.org

[yhanada, 2016-10-26 12:12:09]

Hi oshima@! Could you please take a look at this CL?
As it's under discussion that which screen should have the virtual keyboard,
implementation of Shell::CreateKeyboard() will change slightly, but other parts
are ready to review.
Any comments or suggestions would be highly appreciated!

[yhanada, 2016-10-26 12:26:37]

Description was changed from

==========
Make the virtual keyboard show up on the display with input focus.

BUG=303429
TEST=Connect the secondary display. Verify that the virtual
     keyboard or the accessibility on-screen keyboard follows
     the input focus.
==========

to

==========
Make the virtual keyboard show up on the display with input focus.

In order to make the virtual keyboard follow the input focus,
this CL did:
- Hooking focus change events
- If newly focused window is in different display from a display
  which has the virtual keyboard currently, re-creating the virtual
  keyboard in the display which has the focused window

BUG=303429
TEST=Connect the secondary display. Verify that the virtual
     keyboard or the accessibility on-screen keyboard follows
     the input focus.
==========

[yhanada1, 2016-10-26 15:39:39]

yhanada@google.com changed reviewers:
+ yhanada@google.com

[yhanada1, 2016-10-26 15:39:40]

I found some issues on this CL and will fix it tomorrow. Please ignore this CL
for now. I'm sorry to bother you.

[yhanada, 2016-10-27 07:40:16]

Description was changed from

==========
Make the virtual keyboard show up on the display with input focus.

In order to make the virtual keyboard follow the input focus,
this CL did:
- Hooking focus change events
- If newly focused window is in different display from a display
  which has the virtual keyboard currently, re-creating the virtual
  keyboard in the display which has the focused window

BUG=303429
TEST=Connect the secondary display. Verify that the virtual
     keyboard or the accessibility on-screen keyboard follows
     the input focus.
==========

to

==========
Let the virtual keyboard show up on the secondary screen.
    
This CL let the virtual keyboard show up on a display if
the display has touch capability and the input focus goes to
a window in that display.
    
BUG=303429
TEST=Connect the secondary display. Verify that the virtual
     keyboard or the accessibility on-screen keyboard follows
     the input focus if the focused window is in the display
     which has touch capability.
==========

[yhanada, 2016-10-27 07:40:16]

yhanada@chromium.org changed reviewers:
- yhanada@google.com

[yhanada, 2016-10-27 07:42:15]

I modified this CL to follow your idea in crbug.com/303429. PTAL. Thanks!

[yhanada, 2016-10-27 07:47:11]

The CQ bit was checked by yhanada@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-27 07:47:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-27 09:09:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-27 09:09:55]

Dry run: This issue passed the CQ dry run.

[yhanada, 2016-10-31 08:46:40]

Description was changed from

==========
Let the virtual keyboard show up on the secondary screen.
    
This CL let the virtual keyboard show up on a display if
the display has touch capability and the input focus goes to
a window in that display.
    
BUG=303429
TEST=Connect the secondary display. Verify that the virtual
     keyboard or the accessibility on-screen keyboard follows
     the input focus if the focused window is in the display
     which has touch capability.
==========

to

==========
Let the virtual keyboard show up on the secondary screen.
    
This CL let the virtual keyboard show up on a display if
1. the display has touch capability and the input focus goes to
   a window in that display.
2. the keyboard icon in the tray in that display is pressed.
    
BUG=303429
TEST=Connect the secondary display. Verify that the virtual
     keyboard or the accessibility on-screen keyboard follows
     the input focus if the focused window is in the display
     which has touch capability.
TEST=Added unit tests in root_window_controller_unittest.cc
==========

[oshima, 2016-11-08 17:26:05]

https://codereview.chromium.org/2445293002/diff/100001/ash/common/keyboard/ke...
File ash/common/keyboard/keyboard_ui.h (right):

https://codereview.chromium.org/2445293002/diff/100001/ash/common/keyboard/ke...
ash/common/keyboard/keyboard_ui.h:27: virtual void ShowInSpecificDisplay(const
int64_t display_id) = 0;
ShowInDisplay

https://codereview.chromium.org/2445293002/diff/100001/ash/common/system/chro...
File ash/common/system/chromeos/virtual_keyboard/virtual_keyboard_tray.cc
(right):

https://codereview.chromium.org/2445293002/diff/100001/ash/common/system/chro...
ash/common/system/chromeos/virtual_keyboard/virtual_keyboard_tray.cc:34:
display_id_(wm_shelf->GetWindow()->GetDisplayNearestWindow().id()),
This mapping may change. Please get this when showing the keyboard.

https://codereview.chromium.org/2445293002/diff/100001/ash/mus/keyboard_ui_mu...
File ash/mus/keyboard_ui_mus.cc (right):

https://codereview.chromium.org/2445293002/diff/100001/ash/mus/keyboard_ui_mu...
ash/mus/keyboard_ui_mus.cc:39: // TODO(yhanada): Send display id
can you file a bug and add reference to it?

https://codereview.chromium.org/2445293002/diff/100001/ash/mus/keyboard_ui_mus.h
File ash/mus/keyboard_ui_mus.h (right):

https://codereview.chromium.org/2445293002/diff/100001/ash/mus/keyboard_ui_mu...
ash/mus/keyboard_ui_mus.h:35: void ShowInSpecificDisplay(int64_t display_id)
override;
ShowInDisplay

https://codereview.chromium.org/2445293002/diff/100001/ash/root_window_contro...
File ash/root_window_controller_unittest.cc (right):

https://codereview.chromium.org/2445293002/diff/100001/ash/root_window_contro...
ash/root_window_controller_unittest.cc:754: // on primary root window if no
window has a focus.
I assume you meant touch capability?

https://codereview.chromium.org/2445293002/diff/100001/ash/root_window_contro...
ash/root_window_controller_unittest.cc:809: }
can you also test that it opens on the secondary display even if the focused
window is on the primary?

https://codereview.chromium.org/2445293002/diff/100001/ash/shell.cc
File ash/shell.cc (right):

https://codereview.chromium.org/2445293002/diff/100001/ash/shell.cc#newcode845
ash/shell.cc:845: #if defined(OS_CHROMEOS)
do you need this? (ash is technically chromeos)

https://codereview.chromium.org/2445293002/diff/100001/ash/virtual_keyboard_c...
File ash/virtual_keyboard_controller.cc (right):

https://codereview.chromium.org/2445293002/diff/100001/ash/virtual_keyboard_c...
ash/virtual_keyboard_controller.cc:109: controller->GetRootWindow());
can you use

Screen::GetAllDisplays ?

https://codereview.chromium.org/2445293002/diff/100001/ui/keyboard/keyboard_c...
File ui/keyboard/keyboard_controller.cc (right):

https://codereview.chromium.org/2445293002/diff/100001/ui/keyboard/keyboard_c...
ui/keyboard/keyboard_controller.cc:425: }
nuke {}

https://codereview.chromium.org/2445293002/diff/100001/ui/keyboard/keyboard_c...
File ui/keyboard/keyboard_controller.h (right):

https://codereview.chromium.org/2445293002/diff/100001/ui/keyboard/keyboard_c...
ui/keyboard/keyboard_controller.h:93: bool get_lock_keyboard() const { return
lock_keyboard_; }
could you please change these to


set_keyboard_locked()
keyboard_locked() const

(and rename lock_keyboard_ -> keyboard_locked_)

?

https://codereview.chromium.org/2445293002/diff/100001/ui/keyboard/keyboard_c...
ui/keyboard/keyboard_controller.h:105: void ShowKeyboardInSpecificDisplay(const
int64_t display_id);
...InDisplay

https://codereview.chromium.org/2445293002/diff/100001/ui/keyboard/keyboard_c...
ui/keyboard/keyboard_controller.h:169: bool lock_keyboard_;
can you document this?

https://codereview.chromium.org/2445293002/diff/100001/ui/keyboard/keyboard_l...
File ui/keyboard/keyboard_layout_delegate.h (right):

https://codereview.chromium.org/2445293002/diff/100001/ui/keyboard/keyboard_l...
ui/keyboard/keyboard_layout_delegate.h:1: // Copyright (c) 2016 The Chromium
Authors. All rights reserved.
remove "(c)" Old files may have it, but it's obsolete.

https://codereview.chromium.org/2445293002/diff/100001/ui/keyboard/keyboard_l...
ui/keyboard/keyboard_layout_delegate.h:22: virtual void
MoveKeyboardToAnotherDisplayIfNeeded(int64_t display_id) = 0;
Since the caller knows which, it's better to have separate method for these two
conditions.

[yhanada, 2016-11-14 22:48:48]

Thank you for reviewing. PTAL.

https://codereview.chromium.org/2445293002/diff/100001/ash/common/keyboard/ke...
File ash/common/keyboard/keyboard_ui.h (right):

https://codereview.chromium.org/2445293002/diff/100001/ash/common/keyboard/ke...
ash/common/keyboard/keyboard_ui.h:27: virtual void ShowInSpecificDisplay(const
int64_t display_id) = 0;
On 2016/11/08 17:26:04, oshima wrote:
> ShowInDisplay

Done.

https://codereview.chromium.org/2445293002/diff/100001/ash/common/system/chro...
File ash/common/system/chromeos/virtual_keyboard/virtual_keyboard_tray.cc
(right):

https://codereview.chromium.org/2445293002/diff/100001/ash/common/system/chro...
ash/common/system/chromeos/virtual_keyboard/virtual_keyboard_tray.cc:34:
display_id_(wm_shelf->GetWindow()->GetDisplayNearestWindow().id()),
On 2016/11/08 17:26:04, oshima wrote:
> This mapping may change. Please get this when showing the keyboard.

Done.

https://codereview.chromium.org/2445293002/diff/100001/ash/mus/keyboard_ui_mu...
File ash/mus/keyboard_ui_mus.cc (right):

https://codereview.chromium.org/2445293002/diff/100001/ash/mus/keyboard_ui_mu...
ash/mus/keyboard_ui_mus.cc:39: // TODO(yhanada): Send display id
On 2016/11/08 17:26:04, oshima wrote:
> can you file a bug and add reference to it?

This TODO depends on the TODO in keyboard.mojom:L18. I added a reference to
crbug.com/585253 which is for it.

https://codereview.chromium.org/2445293002/diff/100001/ash/mus/keyboard_ui_mus.h
File ash/mus/keyboard_ui_mus.h (right):

https://codereview.chromium.org/2445293002/diff/100001/ash/mus/keyboard_ui_mu...
ash/mus/keyboard_ui_mus.h:35: void ShowInSpecificDisplay(int64_t display_id)
override;
On 2016/11/08 17:26:04, oshima wrote:
> ShowInDisplay

Done.

https://codereview.chromium.org/2445293002/diff/100001/ash/root_window_contro...
File ash/root_window_controller_unittest.cc (right):

https://codereview.chromium.org/2445293002/diff/100001/ash/root_window_contro...
ash/root_window_controller_unittest.cc:754: // on primary root window if no
window has a focus.
On 2016/11/08 17:26:04, oshima wrote:
> I assume you meant touch capability?

Done.

https://codereview.chromium.org/2445293002/diff/100001/ash/root_window_contro...
ash/root_window_controller_unittest.cc:809: }
On 2016/11/08 17:26:05, oshima wrote:
> can you also test that it opens on the secondary display even if the focused
> window is on the primary?

Done.

https://codereview.chromium.org/2445293002/diff/100001/ash/shell.cc
File ash/shell.cc (right):

https://codereview.chromium.org/2445293002/diff/100001/ash/shell.cc#newcode845
ash/shell.cc:845: #if defined(OS_CHROMEOS)
On 2016/11/08 17:26:05, oshima wrote:
> do you need this? (ash is technically chromeos)

Yes, because the definition of |virtual_keyboard_controller_| is under
OS_CHROMEOS.

https://codereview.chromium.org/2445293002/diff/100001/ash/virtual_keyboard_c...
File ash/virtual_keyboard_controller.cc (right):

https://codereview.chromium.org/2445293002/diff/100001/ash/virtual_keyboard_c...
ash/virtual_keyboard_controller.cc:109: controller->GetRootWindow());
On 2016/11/08 17:26:05, oshima wrote:
> can you use
> 
> Screen::GetAllDisplays ?

Done. This function is moved into anonymous namespace.

https://codereview.chromium.org/2445293002/diff/100001/ui/keyboard/keyboard_c...
File ui/keyboard/keyboard_controller.cc (right):

https://codereview.chromium.org/2445293002/diff/100001/ui/keyboard/keyboard_c...
ui/keyboard/keyboard_controller.cc:425: }
On 2016/11/08 17:26:05, oshima wrote:
> nuke {}

Done.

https://codereview.chromium.org/2445293002/diff/100001/ui/keyboard/keyboard_c...
File ui/keyboard/keyboard_controller.h (right):

https://codereview.chromium.org/2445293002/diff/100001/ui/keyboard/keyboard_c...
ui/keyboard/keyboard_controller.h:93: bool get_lock_keyboard() const { return
lock_keyboard_; }
On 2016/11/08 17:26:05, oshima wrote:
> could you please change these to
> 
> 
> set_keyboard_locked()
> keyboard_locked() const
> 
> (and rename lock_keyboard_ -> keyboard_locked_)
> 
> ? 

Done.

https://codereview.chromium.org/2445293002/diff/100001/ui/keyboard/keyboard_c...
ui/keyboard/keyboard_controller.h:105: void ShowKeyboardInSpecificDisplay(const
int64_t display_id);
On 2016/11/08 17:26:05, oshima wrote:
> ...InDisplay

Done.

https://codereview.chromium.org/2445293002/diff/100001/ui/keyboard/keyboard_c...
ui/keyboard/keyboard_controller.h:169: bool lock_keyboard_;
On 2016/11/08 17:26:05, oshima wrote:
> can you document this?

Done.

https://codereview.chromium.org/2445293002/diff/100001/ui/keyboard/keyboard_l...
File ui/keyboard/keyboard_layout_delegate.h (right):

https://codereview.chromium.org/2445293002/diff/100001/ui/keyboard/keyboard_l...
ui/keyboard/keyboard_layout_delegate.h:1: // Copyright (c) 2016 The Chromium
Authors. All rights reserved.
On 2016/11/08 17:26:05, oshima wrote:
> remove "(c)" Old files may have it, but it's obsolete.

Done.

https://codereview.chromium.org/2445293002/diff/100001/ui/keyboard/keyboard_l...
ui/keyboard/keyboard_layout_delegate.h:22: virtual void
MoveKeyboardToAnotherDisplayIfNeeded(int64_t display_id) = 0;
On 2016/11/08 17:26:05, oshima wrote:
> Since the caller knows which, it's better to have separate method for these
two
> conditions.

Done.

[yhanada, 2016-11-15 18:51:11]

yhanada@chromium.org changed reviewers:
+ bshe@chromium.org

[yhanada, 2016-11-15 18:51:12]

Hi bshe@, could you take a look at ui/keyboard/* and 
chrome/browser/extensions/api/virtual_keyboard_private/* as an OWNER?

[oshima, 2016-11-16 22:05:02]

lgtm

https://codereview.chromium.org/2445293002/diff/120001/ash/root_window_contro...
File ash/root_window_controller_unittest.cc (right):

https://codereview.chromium.org/2445293002/diff/120001/ash/root_window_contro...
ash/root_window_controller_unittest.cc:822:
ASSERT_FALSE(Shell::GetContainer(primary_root_window,
nit: EXPECT_

https://codereview.chromium.org/2445293002/diff/120001/ash/root_window_contro...
ash/root_window_controller_unittest.cc:825:
kShellWindowId_VirtualKeyboardContainer));
ditto

https://codereview.chromium.org/2445293002/diff/120001/ash/root_window_contro...
ash/root_window_controller_unittest.cc:873:
kShellWindowId_VirtualKeyboardContainer));
ditto

https://codereview.chromium.org/2445293002/diff/120001/ash/root_window_contro...
ash/root_window_controller_unittest.cc:875:
kShellWindowId_VirtualKeyboardContainer));
ditto

https://codereview.chromium.org/2445293002/diff/120001/ash/root_window_contro...
ash/root_window_controller_unittest.cc:893:
kShellWindowId_VirtualKeyboardContainer));
ditto

https://codereview.chromium.org/2445293002/diff/120001/ash/root_window_contro...
ash/root_window_controller_unittest.cc:895:
kShellWindowId_VirtualKeyboardContainer));
ditto

https://codereview.chromium.org/2445293002/diff/120001/ash/root_window_contro...
ash/root_window_controller_unittest.cc:925:
kShellWindowId_VirtualKeyboardContainer));
dotto

https://codereview.chromium.org/2445293002/diff/120001/ash/root_window_contro...
ash/root_window_controller_unittest.cc:927:
kShellWindowId_VirtualKeyboardContainer));
ditto

[yhanada, 2016-11-16 22:22:10]

https://codereview.chromium.org/2445293002/diff/120001/ash/root_window_contro...
File ash/root_window_controller_unittest.cc (right):

https://codereview.chromium.org/2445293002/diff/120001/ash/root_window_contro...
ash/root_window_controller_unittest.cc:822:
ASSERT_FALSE(Shell::GetContainer(primary_root_window,
On 2016/11/16 22:05:02, oshima wrote:
> nit: EXPECT_

Done.

https://codereview.chromium.org/2445293002/diff/120001/ash/root_window_contro...
ash/root_window_controller_unittest.cc:825:
kShellWindowId_VirtualKeyboardContainer));
On 2016/11/16 22:05:02, oshima wrote:
> ditto

Done.

https://codereview.chromium.org/2445293002/diff/120001/ash/root_window_contro...
ash/root_window_controller_unittest.cc:873:
kShellWindowId_VirtualKeyboardContainer));
On 2016/11/16 22:05:02, oshima wrote:
> ditto

Done.

https://codereview.chromium.org/2445293002/diff/120001/ash/root_window_contro...
ash/root_window_controller_unittest.cc:875:
kShellWindowId_VirtualKeyboardContainer));
On 2016/11/16 22:05:02, oshima wrote:
> ditto

Done.

https://codereview.chromium.org/2445293002/diff/120001/ash/root_window_contro...
ash/root_window_controller_unittest.cc:893:
kShellWindowId_VirtualKeyboardContainer));
On 2016/11/16 22:05:02, oshima wrote:
> ditto

Done.

https://codereview.chromium.org/2445293002/diff/120001/ash/root_window_contro...
ash/root_window_controller_unittest.cc:895:
kShellWindowId_VirtualKeyboardContainer));
On 2016/11/16 22:05:02, oshima wrote:
> ditto

Done.

https://codereview.chromium.org/2445293002/diff/120001/ash/root_window_contro...
ash/root_window_controller_unittest.cc:925:
kShellWindowId_VirtualKeyboardContainer));
On 2016/11/16 22:05:02, oshima wrote:
> dotto

Done.

https://codereview.chromium.org/2445293002/diff/120001/ash/root_window_contro...
ash/root_window_controller_unittest.cc:927:
kShellWindowId_VirtualKeyboardContainer));
On 2016/11/16 22:05:02, oshima wrote:
> ditto

Done.

[yhanada, 2016-11-17 18:17:21]

bshe@: ping?

[bshe, 2016-11-21 19:48:25]

On 2016/11/17 18:17:21, yhanada wrote:
> bshe@: ping?

Sorry for the delay!
lgtm

[yhanada, 2016-11-24 05:16:56]

The CQ bit was checked by yhanada@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-24 05:17:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-24 05:23:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-24 05:23:32]

Dry run: Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[yhanada, 2016-11-24 05:38:12]

The CQ bit was checked by yhanada@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-24 05:38:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yhanada, 2016-11-24 06:14:17]

Thank you for reviewing!

[yhanada, 2016-11-24 06:14:25]

The CQ bit was checked by yhanada@chromium.org

[yhanada, 2016-11-24 06:14:25]

The patchset sent to the CQ was uploaded after l-g-t-m from oshima@chromium.org,
bshe@chromium.org
Link to the patchset: https://codereview.chromium.org/2445293002/#ps200001
(title: "fix a compilation error on Windows.")

[commit-bot: I haz the power, 2016-11-24 06:14:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yhanada, 2016-11-24 06:27:22]

The CQ bit was checked by yhanada@chromium.org

[yhanada, 2016-11-24 06:27:23]

The patchset sent to the CQ was uploaded after l-g-t-m from oshima@chromium.org,
bshe@chromium.org
Link to the patchset: https://codereview.chromium.org/2445293002/#ps220001
(title: "fix one more compilation error on Windows")

[commit-bot: I haz the power, 2016-11-24 06:27:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-24 08:28:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-24 08:28:52]

Try jobs failed on following builders:
  blimp_linux_dbg on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
no build URL)
  linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_clobber_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)

[yhanada, 2016-11-24 23:16:35]

The CQ bit was checked by yhanada@chromium.org

[commit-bot: I haz the power, 2016-11-24 23:16:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-25 00:03:22]

CQ is committing da patch.

Bot data: {"patchset_id": 220001, "attempt_start_ts": 1480029395686640,
"parent_rev": "0abae00c35ac2de8e8f555ce7f39573ab68b7ca4", "commit_rev":
"3a12c487616470aa619818b455f5757935c028b8"}

[commit-bot: I haz the power, 2016-11-25 00:03:44]

Description was changed from

==========
Let the virtual keyboard show up on the secondary screen.
    
This CL let the virtual keyboard show up on a display if
1. the display has touch capability and the input focus goes to
   a window in that display.
2. the keyboard icon in the tray in that display is pressed.
    
BUG=303429
TEST=Connect the secondary display. Verify that the virtual
     keyboard or the accessibility on-screen keyboard follows
     the input focus if the focused window is in the display
     which has touch capability.
TEST=Added unit tests in root_window_controller_unittest.cc
==========

to

==========
Let the virtual keyboard show up on the secondary screen.
    
This CL let the virtual keyboard show up on a display if
1. the display has touch capability and the input focus goes to
   a window in that display.
2. the keyboard icon in the tray in that display is pressed.
    
BUG=303429
TEST=Connect the secondary display. Verify that the virtual
     keyboard or the accessibility on-screen keyboard follows
     the input focus if the focused window is in the display
     which has touch capability.
TEST=Added unit tests in root_window_controller_unittest.cc
==========

[commit-bot: I haz the power, 2016-11-25 00:03:45]

Committed patchset #12 (id:220001)

[commit-bot: I haz the power, 2016-11-25 00:05:53]

Description was changed from

==========
Let the virtual keyboard show up on the secondary screen.
    
This CL let the virtual keyboard show up on a display if
1. the display has touch capability and the input focus goes to
   a window in that display.
2. the keyboard icon in the tray in that display is pressed.
    
BUG=303429
TEST=Connect the secondary display. Verify that the virtual
     keyboard or the accessibility on-screen keyboard follows
     the input focus if the focused window is in the display
     which has touch capability.
TEST=Added unit tests in root_window_controller_unittest.cc
==========

to

==========
Let the virtual keyboard show up on the secondary screen.

This CL let the virtual keyboard show up on a display if
1. the display has touch capability and the input focus goes to
   a window in that display.
2. the keyboard icon in the tray in that display is pressed.

BUG=303429
TEST=Connect the secondary display. Verify that the virtual
     keyboard or the accessibility on-screen keyboard follows
     the input focus if the focused window is in the display
     which has touch capability.
TEST=Added unit tests in root_window_controller_unittest.cc

Committed: https://crrev.com/7e20c9b1abf3784127b729a7fcd820e11a78afc9
Cr-Commit-Position: refs/heads/master@{#434409}
==========

[commit-bot: I haz the power, 2016-11-25 00:05:54]

Patchset 12 (id:??) landed as
https://crrev.com/7e20c9b1abf3784127b729a7fcd820e11a78afc9
Cr-Commit-Position: refs/heads/master@{#434409}