Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issue 2444733002: [GeometryInterface] Add rotate*(), rotateFromVector*() function. (Closed)

Created:
4 years, 2 months ago by Hwanseung Lee
Modified:
4 years, 1 month ago
CC:
blink-reviews, blink-reviews-dom_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, Hwanseung Lee(hs1217.lee), rwlbuis, sof
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[GeometryInterface] Add rotate*(), rotateFromVector*() function. rotate() and rotateSelf() function 1. If rotY and rotZ are both missing, set rotZ to the value of rotX and set rotX and rotY to zero. 2. If rotY is still missing, set rotY to zero. 3. If rotZ is still missing, set rotZ to zero. 4. If rotX or rotY are non-zero, set is2D of the current matrix to false. 5. Post-multiply a rotation transformation on the current matrix around the vector 0, 0, 1 by the specified rotation rotZ in degrees. 6. Post-multiply a rotation transformation on the current matrix around the vector 0, 1, 0 by the specified rotation rotY in degrees. 7. Post-multiply a rotation transformation on the current matrix around the vector 1, 0, 0 by the specified rotation rotX in degrees. 8. Return the current matrix. rotateFromVertor() and rotateFromVertorSelf() function 1. Post-multiply a rotation transformation on the current matrix. The rotation angle is determined by the angle between the vector (1,0)T and (x,y)T in the clockwise direction. 2. Return the current matrix. spec list: - https://drafts.fxtf.org/geometry/#dom-dommatrix-rotateself - https://drafts.fxtf.org/geometry/#dom-dommatrixreadonly-rotate - https://drafts.fxtf.org/geometry/#dom-dommatrix-rotatefromvectorself - https://drafts.fxtf.org/geometry/#dom-dommatrixreadonly-rotatefromvector BUG=388780, 645878, 645882 Committed: https://crrev.com/66e25541d7b2df4771ad675d96a25ad32f42588f Cr-Commit-Position: refs/heads/master@{#427289}

Patch Set 1 #

Total comments: 7

Patch Set 2 : update test file. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+264 lines, -106 lines) Patch
M third_party/WebKit/LayoutTests/fast/dom/geometry-interfaces-dom-matrix-rotate.html View 1 2 chunks +196 lines, -106 lines 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt View 2 chunks +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/DOMMatrix.h View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/DOMMatrix.cpp View 1 chunk +30 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/DOMMatrix.idl View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/DOMMatrixReadOnly.h View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/DOMMatrixReadOnly.cpp View 1 chunk +16 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/DOMMatrixReadOnly.idl View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 27 (18 generated)
Hwanseung Lee
@dominicc, zino PTAL, thank you.
4 years, 2 months ago (2016-10-23 08:39:22 UTC) #6
dominicc (has gone to gerrit)
+meade who is working on CSS typed OM and is able to review this.
4 years, 1 month ago (2016-10-24 02:56:54 UTC) #8
meade_UTC10
I only have a few relatively minor comments on this. +Tim for OWNERS. https://codereview.chromium.org/2444733002/diff/1/third_party/WebKit/LayoutTests/fast/dom/geometry-interfaces-dom-matrix-rotate.html File ...
4 years, 1 month ago (2016-10-24 05:37:11 UTC) #12
Hwanseung Lee
@Eddy i comment about default parameter. https://codereview.chromium.org/2444733002/diff/1/third_party/WebKit/LayoutTests/fast/dom/geometry-interfaces-dom-matrix-rotate.html File third_party/WebKit/LayoutTests/fast/dom/geometry-interfaces-dom-matrix-rotate.html (right): https://codereview.chromium.org/2444733002/diff/1/third_party/WebKit/LayoutTests/fast/dom/geometry-interfaces-dom-matrix-rotate.html#newcode60 third_party/WebKit/LayoutTests/fast/dom/geometry-interfaces-dom-matrix-rotate.html:60: assert_matrix_almost_equals(matrix, expectedMatrix); On ...
4 years, 1 month ago (2016-10-24 14:33:43 UTC) #15
meade_UTC10
lgtm Thanks for the clarifications. Tim, PTAL https://codereview.chromium.org/2444733002/diff/1/third_party/WebKit/Source/core/dom/DOMMatrix.h File third_party/WebKit/Source/core/dom/DOMMatrix.h (right): https://codereview.chromium.org/2444733002/diff/1/third_party/WebKit/Source/core/dom/DOMMatrix.h#newcode97 third_party/WebKit/Source/core/dom/DOMMatrix.h:97: DOMMatrix* rotateSelf(double ...
4 years, 1 month ago (2016-10-25 02:33:05 UTC) #16
Timothy Loh
lgtm
4 years, 1 month ago (2016-10-25 05:24:42 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2444733002/20001
4 years, 1 month ago (2016-10-25 06:33:48 UTC) #23
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-10-25 06:38:11 UTC) #25
commit-bot: I haz the power
4 years, 1 month ago (2016-10-25 06:42:02 UTC) #27
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/66e25541d7b2df4771ad675d96a25ad32f42588f
Cr-Commit-Position: refs/heads/master@{#427289}

Powered by Google App Engine
This is Rietveld 408576698