Issue 2421773002: Fix android_webview FindBugs warnings revealed by N sdk

Issue 2421773002: Fix android_webview FindBugs warnings revealed by N sdk (Closed)

Created:
4 years, 2 months ago by agrieve

Modified:
4 years, 2 months ago

Reviewers:
Torne

CC:
chromium-reviews, jam, darin-cc_chromium.org, android-webview-reviews_chromium.org, agrieve+watch_chromium.org, ghost stip (do not use)

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Fix android_webview FindBugs warnings revealed by N sdk BUG=623989 Committed: https://crrev.com/3cf5ff3ea3a36eff9a9178369dc093f01fb80f25 Cr-Commit-Position: refs/heads/master@{#425305}

Created: 4 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+16 lines, -4 lines)			Patch
M	android_webview/glue/java/src/com/android/webview/chromium/WebHistoryItemChromium.java	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	android_webview/javatests/src/org/chromium/android_webview/test/AwJavaBridgeTest.java	View	4 chunks	+4 lines, -0 lines	0 comments	Download
M	android_webview/javatests/src/org/chromium/android_webview/test/LoadDataWithBaseUrlTest.java	View	1 chunk	+5 lines, -2 lines	0 comments	Download
M	android_webview/javatests/src/org/chromium/android_webview/test/VisualStateTest.java	View	2 chunks	+2 lines, -0 lines	0 comments	Download
M	content/public/android/javatests/src/org/chromium/content/browser/JavaBridgeBasicsTest.java	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	content/public/android/javatests/src/org/chromium/content/browser/JavaBridgeChildFrameTest.java	View	1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 14 (9 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2421773002/1

4 years, 2 months ago (2016-10-14 12:48:22 UTC) #10

commit-bot: I haz the power

4 years, 2 months ago (2016-10-14 12:55:45 UTC) #14

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/3cf5ff3ea3a36eff9a9178369dc093f01fb80f25
Cr-Commit-Position: refs/heads/master@{#425305}