Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Side by Side Diff: android_webview/glue/java/src/com/android/webview/chromium/WebHistoryItemChromium.java

Issue 2421773002: Fix android_webview FindBugs warnings revealed by N sdk (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | android_webview/javatests/src/org/chromium/android_webview/test/AwJavaBridgeTest.java » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 package com.android.webview.chromium; 5 package com.android.webview.chromium;
6 6
7 import android.graphics.Bitmap; 7 import android.graphics.Bitmap;
8 import android.webkit.WebHistoryItem; 8 import android.webkit.WebHistoryItem;
9 9
10 import org.chromium.base.annotations.SuppressFBWarnings; 10 import org.chromium.base.annotations.SuppressFBWarnings;
(...skipping 64 matching lines...) Expand 10 before | Expand all | Expand 10 after
75 mOriginalUrl = originalUrl; 75 mOriginalUrl = originalUrl;
76 mTitle = title; 76 mTitle = title;
77 mFavicon = favicon; 77 mFavicon = favicon;
78 } 78 }
79 79
80 /** 80 /**
81 * See {@link android.webkit.WebHistoryItem#clone}. 81 * See {@link android.webkit.WebHistoryItem#clone}.
82 */ 82 */
83 @SuppressFBWarnings({ 83 @SuppressFBWarnings({
84 "CHROMIUM_SYNCHRONIZED_METHOD", 84 "CHROMIUM_SYNCHRONIZED_METHOD",
85 "CN_IDIOM_NO_SUPER_CALL"}) 85 "CN_IDIOM_NO_SUPER_CALL",
86 "CN_IMPLEMENTS_CLONE_BUT_NOT_CLONEABLE"})
86 @Override 87 @Override
87 public synchronized WebHistoryItemChromium clone() { 88 public synchronized WebHistoryItemChromium clone() {
88 return new WebHistoryItemChromium(mUrl, mOriginalUrl, mTitle, mFavicon); 89 return new WebHistoryItemChromium(mUrl, mOriginalUrl, mTitle, mFavicon);
89 } 90 }
90 } 91 }
OLDNEW
« no previous file with comments | « no previous file | android_webview/javatests/src/org/chromium/android_webview/test/AwJavaBridgeTest.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698