android_webview/javatests/src/org/chromium/android_webview/test/LoadDataWithBaseUrlTest.java - Issue 2421773002: Fix android_webview FindBugs warnings revealed by N sdk

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/javatests/src/org/chromium/android_webview/test/LoadDataWithBaseUrlTest.java

Issue 2421773002: Fix android_webview FindBugs warnings revealed by N sdk (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « android_webview/javatests/src/org/chromium/android_webview/test/AwJavaBridgeTest.java ('k') | android_webview/javatests/src/org/chromium/android_webview/test/VisualStateTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: android_webview/javatests/src/org/chromium/android_webview/test/LoadDataWithBaseUrlTest.java

diff --git a/android_webview/javatests/src/org/chromium/android_webview/test/LoadDataWithBaseUrlTest.java b/android_webview/javatests/src/org/chromium/android_webview/test/LoadDataWithBaseUrlTest.java

index 09f5b97e9adb9089b781dfa2a27006562c3af932..979d105dabe31f33d14b0994e69de7607a23ad7c 100644

--- a/android_webview/javatests/src/org/chromium/android_webview/test/LoadDataWithBaseUrlTest.java

+++ b/android_webview/javatests/src/org/chromium/android_webview/test/LoadDataWithBaseUrlTest.java

@@ -301,8 +301,11 @@ public class LoadDataWithBaseUrlTest extends AwTestBase {

File tempImage = File.createTempFile("test_image", ".png", cacheDir);

Bitmap bitmap = Bitmap.createBitmap(1, 1, Bitmap.Config.RGB_565);

FileOutputStream fos = new FileOutputStream(tempImage);

- bitmap.compress(Bitmap.CompressFormat.PNG, 100, fos);

- fos.close();

+ try {

+ bitmap.compress(Bitmap.CompressFormat.PNG, 100, fos);

+ } finally {

+ fos.close();

+ }

String imagePath = tempImage.getAbsolutePath();

AwSettings contentSettings = getAwSettingsOnUiThread(mAwContents);