Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2000)

Unified Diff: android_webview/glue/java/src/com/android/webview/chromium/WebHistoryItemChromium.java

Issue 2421773002: Fix android_webview FindBugs warnings revealed by N sdk (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | android_webview/javatests/src/org/chromium/android_webview/test/AwJavaBridgeTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: android_webview/glue/java/src/com/android/webview/chromium/WebHistoryItemChromium.java
diff --git a/android_webview/glue/java/src/com/android/webview/chromium/WebHistoryItemChromium.java b/android_webview/glue/java/src/com/android/webview/chromium/WebHistoryItemChromium.java
index 5a93abc9c4f0a9e203b64270c34e1ff5fdcc20cf..d492bdff3a64a560f8a5f138de1b4fb21a4ffe30 100644
--- a/android_webview/glue/java/src/com/android/webview/chromium/WebHistoryItemChromium.java
+++ b/android_webview/glue/java/src/com/android/webview/chromium/WebHistoryItemChromium.java
@@ -82,7 +82,8 @@ public class WebHistoryItemChromium extends WebHistoryItem {
*/
@SuppressFBWarnings({
"CHROMIUM_SYNCHRONIZED_METHOD",
- "CN_IDIOM_NO_SUPER_CALL"})
+ "CN_IDIOM_NO_SUPER_CALL",
+ "CN_IMPLEMENTS_CLONE_BUT_NOT_CLONEABLE"})
@Override
public synchronized WebHistoryItemChromium clone() {
return new WebHistoryItemChromium(mUrl, mOriginalUrl, mTitle, mFavicon);
« no previous file with comments | « no previous file | android_webview/javatests/src/org/chromium/android_webview/test/AwJavaBridgeTest.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698