Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Unified Diff: android_webview/javatests/src/org/chromium/android_webview/test/AwJavaBridgeTest.java

Issue 2421773002: Fix android_webview FindBugs warnings revealed by N sdk (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: android_webview/javatests/src/org/chromium/android_webview/test/AwJavaBridgeTest.java
diff --git a/android_webview/javatests/src/org/chromium/android_webview/test/AwJavaBridgeTest.java b/android_webview/javatests/src/org/chromium/android_webview/test/AwJavaBridgeTest.java
index 502deef1c22d31585a774cefc657208525aee2e7..f720843fe50048ec999b636e6e259ff7a8657b76 100644
--- a/android_webview/javatests/src/org/chromium/android_webview/test/AwJavaBridgeTest.java
+++ b/android_webview/javatests/src/org/chromium/android_webview/test/AwJavaBridgeTest.java
@@ -8,6 +8,7 @@ import android.test.suitebuilder.annotation.SmallTest;
import android.webkit.JavascriptInterface;
import org.chromium.android_webview.AwContents;
+import org.chromium.base.annotations.SuppressFBWarnings;
import org.chromium.base.test.util.Feature;
/**
@@ -32,6 +33,7 @@ public class AwJavaBridgeTest extends AwTestBase {
final AwTestContainerView view2 = createAwTestContainerViewOnMainSync(client2);
final AwContents awContents = mTestContainerView.getAwContents();
+ @SuppressFBWarnings("UMAC_UNCALLABLE_METHOD_OF_ANONYMOUS_CLASS")
class Test {
@JavascriptInterface
public void destroy() {
@@ -87,6 +89,7 @@ public class AwJavaBridgeTest extends AwTestBase {
Test(int value) {
mValue = value;
}
+ @SuppressFBWarnings("UMAC_UNCALLABLE_METHOD_OF_ANONYMOUS_CLASS")
@JavascriptInterface
public int getValue() {
return mValue;
@@ -123,6 +126,7 @@ public class AwJavaBridgeTest extends AwTestBase {
Test(int value) {
mValue = value;
}
+ @SuppressFBWarnings("UMAC_UNCALLABLE_METHOD_OF_ANONYMOUS_CLASS")
@JavascriptInterface
public int getValue() {
return mValue;

Powered by Google App Engine
This is Rietveld 408576698