AudioParams with automations must process timelines

AudioParams with automations must process timelines

Currently, if an AudioNode has no inputs connected, any automations
(or connections) to an AudioParam of the node is not processed.  Thus,
time never advances on the AudioParam, and any upstream graph
connected to the AudioParam never gets pulled for data.

AudioParam should get processed so that time progresses.  Normal
processing of the node causes AudioParams to be processed, so we were
only missing the case where the node has silent inputs (silent or no
inputs).  Then we just need to update the AudioParams, without having
to do the full processing associated with the node.

See https://webaudio.github.io/web-audio-api/#rendering-loop, step 8.1.1
in particular that says any inputs connected to an AudioParam are 
processed.  There are no conditions on when this happens.

BUG=647974
TEST=audioparam-processing.html

Review-Url: https://codereview.chromium.org/2420983002
Cr-Commit-Position: refs/heads/master@{#442662}
Committed: https://chromium.googlesource.com/chromium/src/+/69350f73e4ed47dac12cb087ee4bb6ec64a12a2b

[Raymond Toy, 2016-10-14 22:26:36]

The CQ bit was checked by rtoy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-14 22:26:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-14 23:10:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-14 23:10:09]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Raymond Toy, 2016-10-18 21:20:50]

Description was changed from

==========
AudioParams with automations must process timelines

Currently, if an AudioNode has no inputs connected, any automations
(or connections) to an AudioParam of the node is not processed.  Thus,
time never advances on the AudioParam, and any upstream graph
connected to the AudioParam never gets pulled for data.

AudioParam should get processed so that time progresses.  Normal
processing of the node causes AudioParams to be processed, so we were
only missing the case where the node has silent inputs (silent or no
inputs).  Then we just need to update the AudioParams, without having
to do the full processing associated with the node.

BUG=647974
TEST=audioparam-processing.html

Add test file
==========

to

==========
AudioParams with automations must process timelines

Currently, if an AudioNode has no inputs connected, any automations
(or connections) to an AudioParam of the node is not processed.  Thus,
time never advances on the AudioParam, and any upstream graph
connected to the AudioParam never gets pulled for data.

AudioParam should get processed so that time progresses.  Normal
processing of the node causes AudioParams to be processed, so we were
only missing the case where the node has silent inputs (silent or no
inputs).  Then we just need to update the AudioParams, without having
to do the full processing associated with the node.

See https://webaudio.github.io/web-audio-api/#rendering-loop, step 8.1.1 in
particular that says any inputs connected to an AudioParam are processed.  There
are no conditions on when this happens.

BUG=647974
TEST=audioparam-processing.html

Add test file
==========

[Raymond Toy, 2016-10-18 21:21:11]

Description was changed from

==========
AudioParams with automations must process timelines

Currently, if an AudioNode has no inputs connected, any automations
(or connections) to an AudioParam of the node is not processed.  Thus,
time never advances on the AudioParam, and any upstream graph
connected to the AudioParam never gets pulled for data.

AudioParam should get processed so that time progresses.  Normal
processing of the node causes AudioParams to be processed, so we were
only missing the case where the node has silent inputs (silent or no
inputs).  Then we just need to update the AudioParams, without having
to do the full processing associated with the node.

See https://webaudio.github.io/web-audio-api/#rendering-loop, step 8.1.1 in
particular that says any inputs connected to an AudioParam are processed.  There
are no conditions on when this happens.

BUG=647974
TEST=audioparam-processing.html

Add test file
==========

to

==========
AudioParams with automations must process timelines

Currently, if an AudioNode has no inputs connected, any automations
(or connections) to an AudioParam of the node is not processed.  Thus,
time never advances on the AudioParam, and any upstream graph
connected to the AudioParam never gets pulled for data.

AudioParam should get processed so that time progresses.  Normal
processing of the node causes AudioParams to be processed, so we were
only missing the case where the node has silent inputs (silent or no
inputs).  Then we just need to update the AudioParams, without having
to do the full processing associated with the node.

See https://webaudio.github.io/web-audio-api/#rendering-loop, step 8.1.1
in particular that says any inputs connected to an AudioParam are 
processed.  There are no conditions on when this happens.

BUG=647974
TEST=audioparam-processing.html

Add test file
==========

[Raymond Toy, 2016-11-01 16:32:29]

Description was changed from

==========
AudioParams with automations must process timelines

Currently, if an AudioNode has no inputs connected, any automations
(or connections) to an AudioParam of the node is not processed.  Thus,
time never advances on the AudioParam, and any upstream graph
connected to the AudioParam never gets pulled for data.

AudioParam should get processed so that time progresses.  Normal
processing of the node causes AudioParams to be processed, so we were
only missing the case where the node has silent inputs (silent or no
inputs).  Then we just need to update the AudioParams, without having
to do the full processing associated with the node.

See https://webaudio.github.io/web-audio-api/#rendering-loop, step 8.1.1
in particular that says any inputs connected to an AudioParam are 
processed.  There are no conditions on when this happens.

BUG=647974
TEST=audioparam-processing.html

Add test file
==========

to

==========
AudioParams with automations must process timelines

Currently, if an AudioNode has no inputs connected, any automations
(or connections) to an AudioParam of the node is not processed.  Thus,
time never advances on the AudioParam, and any upstream graph
connected to the AudioParam never gets pulled for data.

AudioParam should get processed so that time progresses.  Normal
processing of the node causes AudioParams to be processed, so we were
only missing the case where the node has silent inputs (silent or no
inputs).  Then we just need to update the AudioParams, without having
to do the full processing associated with the node.

See https://webaudio.github.io/web-audio-api/#rendering-loop, step 8.1.1
in particular that says any inputs connected to an AudioParam are 
processed.  There are no conditions on when this happens.

BUG=647974
TEST=audioparam-processing.html
==========

[Raymond Toy, 2016-11-01 16:47:44]

The CQ bit was checked by rtoy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-01 16:48:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Raymond Toy, 2016-11-01 16:49:53]

rtoy@chromium.org changed reviewers:
+ hongchan@chromium.org

[Raymond Toy, 2016-11-01 16:49:54]

PTAL.

Source nodes aren't included here because it's not clear how to handle that.
(Spec issue.)

[commit-bot: I haz the power, 2016-11-01 18:15:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-01 18:15:42]

Dry run: This issue passed the CQ dry run.

[Raymond Toy, 2016-11-07 22:09:32]

Ping.

[hongchan, 2016-11-07 22:17:26]

One request: perhaps we should rename the method to |processAudioParamsOnly|.

https://codereview.chromium.org/2420983002/diff/140001/third_party/WebKit/Sou...
File third_party/WebKit/Source/modules/webaudio/AudioNode.h (right):

https://codereview.chromium.org/2420983002/diff/140001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/webaudio/AudioNode.h:147: virtual void
processAudioParams(size_t framesToProcess){};
Can we rename this to |processAudioParamsOnly|?

[Raymond Toy, 2016-11-07 23:49:24]

https://codereview.chromium.org/2420983002/diff/140001/third_party/WebKit/Sou...
File third_party/WebKit/Source/modules/webaudio/AudioNode.h (right):

https://codereview.chromium.org/2420983002/diff/140001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/webaudio/AudioNode.h:147: virtual void
processAudioParams(size_t framesToProcess){};
On 2016/11/07 22:17:26, hongchan wrote:
> Can we rename this to |processAudioParamsOnly|?

Ok. But grammatically, I think that should be |processOnlyAudioParams|.

[hongchan, 2016-11-07 23:50:14]

On 2016/11/07 23:49:24, Raymond Toy wrote:
>
https://codereview.chromium.org/2420983002/diff/140001/third_party/WebKit/Sou...
> File third_party/WebKit/Source/modules/webaudio/AudioNode.h (right):
> 
>
https://codereview.chromium.org/2420983002/diff/140001/third_party/WebKit/Sou...
> third_party/WebKit/Source/modules/webaudio/AudioNode.h:147: virtual void
> processAudioParams(size_t framesToProcess){};
> On 2016/11/07 22:17:26, hongchan wrote:
> > Can we rename this to |processAudioParamsOnly|?
> 
> Ok. But grammatically, I think that should be |processOnlyAudioParams|.

SGTM.

[hongchan, 2016-11-09 21:23:15]

lgtm

[Raymond Toy, 2017-01-10 17:56:39]

The CQ bit was checked by rtoy@chromium.org

[Raymond Toy, 2017-01-10 17:56:40]

The patchset sent to the CQ was uploaded after l-g-t-m from
hongchan@chromium.org
Link to the patchset: https://codereview.chromium.org/2420983002/#ps220001
(title: "Fix paths.")

[commit-bot: I haz the power, 2017-01-10 17:57:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-10 19:47:21]

CQ is committing da patch.

Bot data: {"patchset_id": 220001, "attempt_start_ts": 1484070999676650,
"parent_rev": "2956e8ee01c51ffab5e2749e8b670855c8d11d99", "commit_rev":
"69350f73e4ed47dac12cb087ee4bb6ec64a12a2b"}

[commit-bot: I haz the power, 2017-01-10 19:47:50]

Description was changed from

==========
AudioParams with automations must process timelines

Currently, if an AudioNode has no inputs connected, any automations
(or connections) to an AudioParam of the node is not processed.  Thus,
time never advances on the AudioParam, and any upstream graph
connected to the AudioParam never gets pulled for data.

AudioParam should get processed so that time progresses.  Normal
processing of the node causes AudioParams to be processed, so we were
only missing the case where the node has silent inputs (silent or no
inputs).  Then we just need to update the AudioParams, without having
to do the full processing associated with the node.

See https://webaudio.github.io/web-audio-api/#rendering-loop, step 8.1.1
in particular that says any inputs connected to an AudioParam are 
processed.  There are no conditions on when this happens.

BUG=647974
TEST=audioparam-processing.html
==========

to

==========
AudioParams with automations must process timelines

Currently, if an AudioNode has no inputs connected, any automations
(or connections) to an AudioParam of the node is not processed.  Thus,
time never advances on the AudioParam, and any upstream graph
connected to the AudioParam never gets pulled for data.

AudioParam should get processed so that time progresses.  Normal
processing of the node causes AudioParams to be processed, so we were
only missing the case where the node has silent inputs (silent or no
inputs).  Then we just need to update the AudioParams, without having
to do the full processing associated with the node.

See https://webaudio.github.io/web-audio-api/#rendering-loop, step 8.1.1
in particular that says any inputs connected to an AudioParam are 
processed.  There are no conditions on when this happens.

BUG=647974
TEST=audioparam-processing.html

Review-Url: https://codereview.chromium.org/2420983002
Cr-Commit-Position: refs/heads/master@{#442662}
Committed:
https://chromium.googlesource.com/chromium/src/+/69350f73e4ed47dac12cb087ee4b...
==========

[commit-bot: I haz the power, 2017-01-10 19:47:51]

Committed patchset #12 (id:220001) as
https://chromium.googlesource.com/chromium/src/+/69350f73e4ed47dac12cb087ee4b...