Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 241753002: NaClSDK: Fix LINK+STRIP make rules to only apply to Release or PNaCl. (Closed)

Created:
6 years, 8 months ago by jvoung (off chromium)
Modified:
6 years, 8 months ago
Reviewers:
binji
CC:
chromium-reviews, binji+watch_chromium.org, native-client-reviews_googlegroups.com, Sam Clegg
Visibility:
Public.

Description

NaClSDK: Fix LINK+STRIP make rules to only apply to Release or PNaCl. Otherwise CONFIG=Debug also ends up with a stripped nexe. Also update the gonacl demo Makefiles and the docs to match. BUG=364220 NOTRY=true (NaCl SDK change only) Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=264691

Patch Set 1 #

Patch Set 2 : english #

Total comments: 2

Patch Set 3 : update comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -22 lines) Patch
M native_client_sdk/doc_generated/devguide/tutorial/tutorial-part2.html View 1 2 3 chunks +8 lines, -4 lines 0 comments Download
M native_client_sdk/src/doc/devguide/tutorial/tutorial-part2.rst View 1 2 3 chunks +8 lines, -4 lines 0 comments Download
M native_client_sdk/src/gonacl_appengine/src/bullet/Makefile View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M native_client_sdk/src/gonacl_appengine/src/cube/Makefile View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M native_client_sdk/src/gonacl_appengine/src/earth/Makefile View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M native_client_sdk/src/gonacl_appengine/src/life/Makefile View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M native_client_sdk/src/gonacl_appengine/src/voronoi/Makefile View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M native_client_sdk/src/resources/Makefile.example.template View 1 2 1 chunk +6 lines, -0 lines 0 comments Download
M native_client_sdk/src/tools/nacl_gcc.mk View 1 chunk +2 lines, -2 lines 0 comments Download
M native_client_sdk/src/tools/nacl_llvm.mk View 2 chunks +5 lines, -7 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
jvoung (off chromium)
6 years, 8 months ago (2014-04-17 21:57:41 UTC) #1
binji
lgtm https://codereview.chromium.org/241753002/diff/20001/native_client_sdk/src/resources/Makefile.example.template File native_client_sdk/src/resources/Makefile.example.template (right): https://codereview.chromium.org/241753002/diff/20001/native_client_sdk/src/resources/Makefile.example.template#newcode100 native_client_sdk/src/resources/Makefile.example.template:100: # Or, only produce a stripped binary for ...
6 years, 8 months ago (2014-04-17 22:02:03 UTC) #2
jvoung (off chromium)
https://codereview.chromium.org/241753002/diff/20001/native_client_sdk/src/resources/Makefile.example.template File native_client_sdk/src/resources/Makefile.example.template (right): https://codereview.chromium.org/241753002/diff/20001/native_client_sdk/src/resources/Makefile.example.template#newcode100 native_client_sdk/src/resources/Makefile.example.template:100: # Or, only produce a stripped binary for Release ...
6 years, 8 months ago (2014-04-17 23:07:09 UTC) #3
jvoung (off chromium)
The CQ bit was checked by jvoung@chromium.org
6 years, 8 months ago (2014-04-18 00:37:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jvoung@chromium.org/241753002/40001
6 years, 8 months ago (2014-04-18 00:37:58 UTC) #5
commit-bot: I haz the power
6 years, 8 months ago (2014-04-18 00:42:02 UTC) #6
Message was sent while issue was closed. 
Change committed as 264691

Powered by Google App Engine
This is Rietveld 408576698