native_client_sdk/src/resources/Makefile.example.template - Issue 241753002: NaClSDK: Fix LINK+STRIP make rules to only apply to Release or PNaCl.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: native_client_sdk/src/resources/Makefile.example.template

Issue 241753002: NaClSDK: Fix LINK+STRIP make rules to only apply to Release or PNaCl. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: english Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.	1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5 # GNU Makefile based on shared rules provided by the Native Client SDK.	5 # GNU Makefile based on shared rules provided by the Native Client SDK.

6 # See README.Makefiles for more details.	6 # See README.Makefiles for more details.

7 [[]]	7 [[]]

8 [[def ExpandDict(key, value_in, pre_list=[], post_list=[]):]]	8 [[def ExpandDict(key, value_in, pre_list=[], post_list=[]):]]

9 [[ value = value_in or [] ]]	9 [[ value = value_in or [] ]]

10 [[ pre = pre_list or [] ]]	10 [[ pre = pre_list or [] ]]

(...skipping 78 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
89 [[ sources = target['NAME'] + '_SOURCES']]	89 [[ sources = target['NAME'] + '_SOURCES']]

90 [[ name = target['NAME'] ]]	90 [[ name = target['NAME'] ]]

91 [[ if len(targets) == 1:]]	91 [[ if len(targets) == 1:]]

92 [[ sources = 'SOURCES']]	92 [[ sources = 'SOURCES']]

93 [[ name = '$(TARGET)']]	93 [[ name = '$(TARGET)']]

94 [[ if target['TYPE'] == 'so':]]	94 [[ if target['TYPE'] == 'so':]]

95 $(eval $(call SO_RULE,{{name}},$({{sources}})))	95 $(eval $(call SO_RULE,{{name}},$({{sources}})))

96 [[ elif target['TYPE'] == 'so-standalone':]]	96 [[ elif target['TYPE'] == 'so-standalone':]]

97 $(eval $(call SO_RULE,{{name}},$({{sources}}),,,1))	97 $(eval $(call SO_RULE,{{name}},$({{sources}}),,,1))

98 [[ else:]]	98 [[ else:]]

	99 # The PNaCl workflow uses both an unstripped and finalized/stripped binary.

	100 # Or, only produce a stripped binary for Release configurations (not Debug).
	binji 2014/04/17 22:02:03 This sentence is a bit strange to me. Maybe "On Na This sentence is a bit strange to me. Maybe "On NaCl, only produce..." jvoung (off chromium) 2014/04/17 23:07:10 Done. Show quoted text On 2014/04/17 22:02:03, binji wrote: > This sentence is a bit strange to me. Maybe "On NaCl, only produce..." Done.
	101 ifneq (,$(or $(findstring pnacl,$(TOOLCHAIN)),$(findstring Release,$(CONFIG))))

99 $(eval $(call LINK_RULE,{{name}}_unstripped,$({{sources}}),$(LIBS),$(DEPS)))	102 $(eval $(call LINK_RULE,{{name}}_unstripped,$({{sources}}),$(LIBS),$(DEPS)))

100 $(eval $(call STRIP_RULE,{{name}},{{name}}_unstripped))	103 $(eval $(call STRIP_RULE,{{name}},{{name}}_unstripped))

	104 else

	105 $(eval $(call LINK_RULE,{{name}},$({{sources}}),$(LIBS),$(DEPS)))

	106 endif

101 [[]]	107 [[]]

102	108

103 $(eval $(call NMF_RULE,$(TARGET),)){{post}}	109 $(eval $(call NMF_RULE,$(TARGET),)){{post}}

OLD	NEW

« no previous file with comments | « native_client_sdk/src/gonacl_appengine/src/voronoi/Makefile ('k') | native_client_sdk/src/tools/nacl_gcc.mk » ('j') | no next file with comments »