native_client_sdk/src/resources/Makefile.example.template - Issue 241753002: NaClSDK: Fix LINK+STRIP make rules to only apply to Release or PNaCl.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: native_client_sdk/src/resources/Makefile.example.template

Issue 241753002: NaClSDK: Fix LINK+STRIP make rules to only apply to Release or PNaCl. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: update comment Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: native_client_sdk/src/resources/Makefile.example.template

diff --git a/native_client_sdk/src/resources/Makefile.example.template b/native_client_sdk/src/resources/Makefile.example.template

index 1c0892a5bf806aca8d2308281759678c35f1d799..7398d3c204cf23a2e5524040d4879e51a976fa4d 100644

--- a/native_client_sdk/src/resources/Makefile.example.template

+++ b/native_client_sdk/src/resources/Makefile.example.template

@@ -96,8 +96,14 @@ $(eval $(call SO_RULE,{{name}},$({{sources}})))

[[ elif target['TYPE'] == 'so-standalone':]]

$(eval $(call SO_RULE,{{name}},$({{sources}}),,,1))

[[ else:]]

+# The PNaCl workflow uses both an unstripped and finalized/stripped binary.

+# On NaCl, only produce a stripped binary for Release configs (not Debug).

+ifneq (,$(or $(findstring pnacl,$(TOOLCHAIN)),$(findstring Release,$(CONFIG))))

$(eval $(call LINK_RULE,{{name}}_unstripped,$({{sources}}),$(LIBS),$(DEPS)))

$(eval $(call STRIP_RULE,{{name}},{{name}}_unstripped))

+else

+$(eval $(call LINK_RULE,{{name}},$({{sources}}),$(LIBS),$(DEPS)))

+endif

[[]]

$(eval $(call NMF_RULE,$(TARGET),)){{post}}