native_client_sdk/src/gonacl_appengine/src/cube/Makefile - Issue 241753002: NaClSDK: Fix LINK+STRIP make rules to only apply to Release or PNaCl.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: native_client_sdk/src/gonacl_appengine/src/cube/Makefile

Issue 241753002: NaClSDK: Fix LINK+STRIP make rules to only apply to Release or PNaCl. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: update comment Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: native_client_sdk/src/gonacl_appengine/src/cube/Makefile

diff --git a/native_client_sdk/src/gonacl_appengine/src/cube/Makefile b/native_client_sdk/src/gonacl_appengine/src/cube/Makefile

index dbd9d63da0b87a51265f71f2c74de09b8eec4dc8..feef4721ee2df0ac66af93bf077fd709181dc962 100644

--- a/native_client_sdk/src/gonacl_appengine/src/cube/Makefile

+++ b/native_client_sdk/src/gonacl_appengine/src/cube/Makefile

@@ -23,7 +23,9 @@ SOURCES = \

$(foreach src,$(SOURCES),$(eval $(call COMPILE_RULE,$(src),$(CFLAGS))))

-ifeq ($(CONFIG),Release)

+# The PNaCl workflow uses both an unstripped and finalized/stripped binary.

+# On NaCl, only produce a stripped binary for Release configs (not Debug).

+ifneq (,$(or $(findstring pnacl,$(TOOLCHAIN)),$(findstring Release,$(CONFIG))))

$(eval $(call LINK_RULE,$(TARGET)_unstripped,$(SOURCES),$(LIBS),$(DEPS)))

$(eval $(call STRIP_RULE,$(TARGET),$(TARGET)_unstripped))

else