native_client_sdk/src/tools/nacl_gcc.mk - Issue 241753002: NaClSDK: Fix LINK+STRIP make rules to only apply to Release or PNaCl.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: native_client_sdk/src/tools/nacl_gcc.mk

Issue 241753002: NaClSDK: Fix LINK+STRIP make rules to only apply to Release or PNaCl. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: update comment Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: native_client_sdk/src/tools/nacl_gcc.mk

diff --git a/native_client_sdk/src/tools/nacl_gcc.mk b/native_client_sdk/src/tools/nacl_gcc.mk

index ddd20d571aed9b2ca127faa3788d0c17ce87c30d..3dae078de01a9cac36c5f49b4ff03ba6c0c5ec75 100644

--- a/native_client_sdk/src/tools/nacl_gcc.mk

+++ b/native_client_sdk/src/tools/nacl_gcc.mk

@@ -437,14 +437,14 @@ ARCH_SUFFIXES := $(foreach arch,$(ARCHES),_$(arch).nexe)

-# NMF Manifiest generation

+# NMF Manifest generation

# Use the python script create_nmf to scan the binaries for dependencies using

# objdump. Pass in the (-L) paths to the default library toolchains so that we

# can find those libraries and have it automatically copy the files (-s) to

# the target directory for us.

-# $1 = Target Name (the basename of the nmf

+# $1 = Target Name (the basename of the nmf)

# $2 = Additional create_nmf.py arguments

NMF := python $(NACL_SDK_ROOT)/tools/create_nmf.py