Account for failure of coordinate space transformations in browser

Account for failure of coordinate space transformations in browser

In some situations, DCHECKs were triggering due to failed
transformations of points between cc::Surface coordinate spaces. This is
because of raciness that can occur when we cache RenderWidgetHostView
pointers: specifically, if the RWHV has changed its Surface due to
(for example) a resize, and the new SurfaceID has not yet propagated
through an embedding renderer process and back to the browser, then
the browser process does not have enough information to compute the
transformation.

This CL allows the RenderWidgetHostInputEventRouter to handle that
situation gracefully, rather than hitting a DCHECK.

BUG=647311
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/9380a25fe8cc25c6c588218a2af44f34a4d115be
Cr-Commit-Position: refs/heads/master@{#425316}

[kenrb, 2016-10-12 16:30:34]

Description was changed from

==========
Account for failure of coordinate space transformations in browser

In some situations, DCHECKs were triggering due to failed
transformations of points between cc::Surface coordinate spaces. This is
because of raciness that can occur when we cache RenderWidgetHostView
pointers: specifically, if the RWHV has changed its Surface due to
(for example) a resize, and the new SurfaceID has not yet propagated
through an embedding renderer process and back to the browser, then
the browser process does not have enough information to compute the
transformation.

This CL allows the RenderWidgetHostInputEventRouter to handle that
situation gracefully, rather than hitting a DCHECK.

BUG=647311
==========

to

==========
Account for failure of coordinate space transformations in browser

In some situations, DCHECKs were triggering due to failed
transformations of points between cc::Surface coordinate spaces. This is
because of raciness that can occur when we cache RenderWidgetHostView
pointers: specifically, if the RWHV has changed its Surface due to
(for example) a resize, and the new SurfaceID has not yet propagated
through an embedding renderer process and back to the browser, then
the browser process does not have enough information to compute the
transformation.

This CL allows the RenderWidgetHostInputEventRouter to handle that
situation gracefully, rather than hitting a DCHECK.

BUG=647311
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[kenrb, 2016-10-12 16:30:43]

The CQ bit was checked by kenrb@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-12 16:30:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-12 16:33:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-12 16:33:50]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[kenrb, 2016-10-12 19:26:17]

The CQ bit was checked by kenrb@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-12 19:26:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-12 20:41:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-12 20:41:41]

Dry run: This issue passed the CQ dry run.

[kenrb, 2016-10-12 23:59:35]

kenrb@chromium.org changed reviewers:
+ nick@chromium.org

[kenrb, 2016-10-12 23:59:36]

Nick: PTAL?

[ncarter (slow), 2016-10-13 20:34:42]

lgtm, just comments

https://codereview.chromium.org/2417463003/diff/20001/content/browser/frame_h...
File content/browser/frame_host/cross_process_frame_connector.h (right):

https://codereview.chromium.org/2417463003/diff/20001/content/browser/frame_h...
content/browser/frame_host/cross_process_frame_connector.h:101: // converted to
the root surface's coordinate space.
Document the return value (and maybe give an example of why failure might
occur?).

https://codereview.chromium.org/2417463003/diff/20001/content/browser/rendere...
File content/browser/renderer_host/delegated_frame_host.h (right):

https://codereview.chromium.org/2417463003/diff/20001/content/browser/rendere...
content/browser/renderer_host/delegated_frame_host.h:165: // same point with no
transform applied.
Update the comment, here and below.

[kenrb, 2016-10-14 13:02:43]

Thanks for the review.

https://codereview.chromium.org/2417463003/diff/20001/content/browser/frame_h...
File content/browser/frame_host/cross_process_frame_connector.h (right):

https://codereview.chromium.org/2417463003/diff/20001/content/browser/frame_h...
content/browser/frame_host/cross_process_frame_connector.h:101: // converted to
the root surface's coordinate space.
On 2016/10/13 20:34:42, ncarter (ooo 10-14 back 10-17) wrote:
> Document the return value (and maybe give an example of why failure might
> occur?).

Done.

https://codereview.chromium.org/2417463003/diff/20001/content/browser/rendere...
File content/browser/renderer_host/delegated_frame_host.h (right):

https://codereview.chromium.org/2417463003/diff/20001/content/browser/rendere...
content/browser/renderer_host/delegated_frame_host.h:165: // same point with no
transform applied.
On 2016/10/13 20:34:42, ncarter (ooo 10-14 back 10-17) wrote:
> Update the comment, here and below.

Done.

[kenrb, 2016-10-14 13:02:49]

The CQ bit was checked by kenrb@chromium.org

[kenrb, 2016-10-14 13:02:49]

The patchset sent to the CQ was uploaded after l-g-t-m from nick@chromium.org
Link to the patchset: https://codereview.chromium.org/2417463003/#ps40001
(title: "Review comments addressed")

[commit-bot: I haz the power, 2016-10-14 13:03:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-14 14:22:06]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-10-14 14:24:03]

Description was changed from

==========
Account for failure of coordinate space transformations in browser

In some situations, DCHECKs were triggering due to failed
transformations of points between cc::Surface coordinate spaces. This is
because of raciness that can occur when we cache RenderWidgetHostView
pointers: specifically, if the RWHV has changed its Surface due to
(for example) a resize, and the new SurfaceID has not yet propagated
through an embedding renderer process and back to the browser, then
the browser process does not have enough information to compute the
transformation.

This CL allows the RenderWidgetHostInputEventRouter to handle that
situation gracefully, rather than hitting a DCHECK.

BUG=647311
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Account for failure of coordinate space transformations in browser

In some situations, DCHECKs were triggering due to failed
transformations of points between cc::Surface coordinate spaces. This is
because of raciness that can occur when we cache RenderWidgetHostView
pointers: specifically, if the RWHV has changed its Surface due to
(for example) a resize, and the new SurfaceID has not yet propagated
through an embedding renderer process and back to the browser, then
the browser process does not have enough information to compute the
transformation.

This CL allows the RenderWidgetHostInputEventRouter to handle that
situation gracefully, rather than hitting a DCHECK.

BUG=647311
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/9380a25fe8cc25c6c588218a2af44f34a4d115be
Cr-Commit-Position: refs/heads/master@{#425316}
==========

[commit-bot: I haz the power, 2016-10-14 14:24:04]

Patchset 3 (id:??) landed as
https://crrev.com/9380a25fe8cc25c6c588218a2af44f34a4d115be
Cr-Commit-Position: refs/heads/master@{#425316}