Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1117)

Unified Diff: content/browser/renderer_host/render_widget_host_view_base.cc

Issue 2417463003: Account for failure of coordinate space transformations in browser (Closed)
Patch Set: Review comments addressed Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_widget_host_view_base.cc
diff --git a/content/browser/renderer_host/render_widget_host_view_base.cc b/content/browser/renderer_host/render_widget_host_view_base.cc
index 28b36981dba2dc16bff3546c10449e317efb8cbb..a0e03e50e2b4c1e66af709659cfc08a86e26b0ac 100644
--- a/content/browser/renderer_host/render_widget_host_view_base.cc
+++ b/content/browser/renderer_host/render_widget_host_view_base.cc
@@ -440,17 +440,20 @@ gfx::PointF RenderWidgetHostViewBase::TransformPointToRootCoordSpaceF(
gfx::ToRoundedPoint(point)));
}
-gfx::Point RenderWidgetHostViewBase::TransformPointToLocalCoordSpace(
+bool RenderWidgetHostViewBase::TransformPointToLocalCoordSpace(
const gfx::Point& point,
- const cc::SurfaceId& original_surface) {
- return point;
+ const cc::SurfaceId& original_surface,
+ gfx::Point* transformed_point) {
+ *transformed_point = point;
+ return true;
}
-gfx::Point RenderWidgetHostViewBase::TransformPointToCoordSpaceForView(
+bool RenderWidgetHostViewBase::TransformPointToCoordSpaceForView(
const gfx::Point& point,
- RenderWidgetHostViewBase* target_view) {
+ RenderWidgetHostViewBase* target_view,
+ gfx::Point* transformed_point) {
NOTREACHED();
- return point;
+ return true;
}
bool RenderWidgetHostViewBase::IsRenderWidgetHostViewGuest() {

Powered by Google App Engine
This is Rietveld 408576698