Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Side by Side Diff: content/browser/renderer_host/render_widget_host_view_base.cc

Issue 2417463003: Account for failure of coordinate space transformations in browser (Closed)
Patch Set: Review comments addressed Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/renderer_host/render_widget_host_view_base.h" 5 #include "content/browser/renderer_host/render_widget_host_view_base.h"
6 6
7 #include "base/logging.h" 7 #include "base/logging.h"
8 #include "build/build_config.h" 8 #include "build/build_config.h"
9 #include "content/browser/accessibility/browser_accessibility_manager.h" 9 #include "content/browser/accessibility/browser_accessibility_manager.h"
10 #include "content/browser/gpu/gpu_data_manager_impl.h" 10 #include "content/browser/gpu/gpu_data_manager_impl.h"
(...skipping 422 matching lines...) Expand 10 before | Expand all | Expand 10 after
433 const gfx::Point& point) { 433 const gfx::Point& point) {
434 return point; 434 return point;
435 } 435 }
436 436
437 gfx::PointF RenderWidgetHostViewBase::TransformPointToRootCoordSpaceF( 437 gfx::PointF RenderWidgetHostViewBase::TransformPointToRootCoordSpaceF(
438 const gfx::PointF& point) { 438 const gfx::PointF& point) {
439 return gfx::PointF(TransformPointToRootCoordSpace( 439 return gfx::PointF(TransformPointToRootCoordSpace(
440 gfx::ToRoundedPoint(point))); 440 gfx::ToRoundedPoint(point)));
441 } 441 }
442 442
443 gfx::Point RenderWidgetHostViewBase::TransformPointToLocalCoordSpace( 443 bool RenderWidgetHostViewBase::TransformPointToLocalCoordSpace(
444 const gfx::Point& point, 444 const gfx::Point& point,
445 const cc::SurfaceId& original_surface) { 445 const cc::SurfaceId& original_surface,
446 return point; 446 gfx::Point* transformed_point) {
447 *transformed_point = point;
448 return true;
447 } 449 }
448 450
449 gfx::Point RenderWidgetHostViewBase::TransformPointToCoordSpaceForView( 451 bool RenderWidgetHostViewBase::TransformPointToCoordSpaceForView(
450 const gfx::Point& point, 452 const gfx::Point& point,
451 RenderWidgetHostViewBase* target_view) { 453 RenderWidgetHostViewBase* target_view,
454 gfx::Point* transformed_point) {
452 NOTREACHED(); 455 NOTREACHED();
453 return point; 456 return true;
454 } 457 }
455 458
456 bool RenderWidgetHostViewBase::IsRenderWidgetHostViewGuest() { 459 bool RenderWidgetHostViewBase::IsRenderWidgetHostViewGuest() {
457 return false; 460 return false;
458 } 461 }
459 462
460 bool RenderWidgetHostViewBase::IsRenderWidgetHostViewChildFrame() { 463 bool RenderWidgetHostViewBase::IsRenderWidgetHostViewChildFrame() {
461 return false; 464 return false;
462 } 465 }
463 466
(...skipping 56 matching lines...) Expand 10 before | Expand all | Expand 10 after
520 523
521 bool RenderWidgetHostViewBase::IsChildFrameForTesting() const { 524 bool RenderWidgetHostViewBase::IsChildFrameForTesting() const {
522 return false; 525 return false;
523 } 526 }
524 527
525 cc::SurfaceId RenderWidgetHostViewBase::SurfaceIdForTesting() const { 528 cc::SurfaceId RenderWidgetHostViewBase::SurfaceIdForTesting() const {
526 return cc::SurfaceId(); 529 return cc::SurfaceId();
527 } 530 }
528 531
529 } // namespace content 532 } // namespace content
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698