Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1220)

Side by Side Diff: content/browser/frame_host/cross_process_frame_connector.h

Issue 2417463003: Account for failure of coordinate space transformations in browser (Closed)
Patch Set: Review comments addressed Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_FRAME_HOST_CROSS_PROCESS_FRAME_CONNECTOR_H_ 5 #ifndef CONTENT_BROWSER_FRAME_HOST_CROSS_PROCESS_FRAME_CONNECTOR_H_
6 #define CONTENT_BROWSER_FRAME_HOST_CROSS_PROCESS_FRAME_CONNECTOR_H_ 6 #define CONTENT_BROWSER_FRAME_HOST_CROSS_PROCESS_FRAME_CONNECTOR_H_
7 7
8 #include <stdint.h> 8 #include <stdint.h>
9 9
10 #include "cc/output/compositor_frame.h" 10 #include "cc/output/compositor_frame.h"
(...skipping 79 matching lines...) Expand 10 before | Expand all | Expand 10 after
90 const gfx::Size& frame_size, 90 const gfx::Size& frame_size,
91 float scale_factor, 91 float scale_factor,
92 const cc::SurfaceSequence& sequence); 92 const cc::SurfaceSequence& sequence);
93 93
94 gfx::Rect ChildFrameRect(); 94 gfx::Rect ChildFrameRect();
95 void UpdateCursor(const WebCursor& cursor); 95 void UpdateCursor(const WebCursor& cursor);
96 gfx::Point TransformPointToRootCoordSpace(const gfx::Point& point, 96 gfx::Point TransformPointToRootCoordSpace(const gfx::Point& point,
97 const cc::SurfaceId& surface_id); 97 const cc::SurfaceId& surface_id);
98 // TransformPointToLocalCoordSpace() can only transform points between 98 // TransformPointToLocalCoordSpace() can only transform points between
99 // surfaces where one is embedded (not necessarily directly) within the 99 // surfaces where one is embedded (not necessarily directly) within the
100 // other. For points that can be in sibling surfaces, they must first be 100 // other, and will return false if this is not the case. For points that can
101 // converted to the root surface's coordinate space. 101 // be in sibling surfaces, they must first be converted to the root
102 gfx::Point TransformPointToLocalCoordSpace( 102 // surface's coordinate space.
103 const gfx::Point& point, 103 bool TransformPointToLocalCoordSpace(const gfx::Point& point,
104 const cc::SurfaceId& original_surface, 104 const cc::SurfaceId& original_surface,
105 const cc::SurfaceId& local_surface_id); 105 const cc::SurfaceId& local_surface_id,
106 gfx::Point TransformPointToCoordSpaceForView( 106 gfx::Point* transformed_point);
107 const gfx::Point& point, 107 // Returns false if |target_view| and |view_| do not have the same root
108 RenderWidgetHostViewBase* target_view, 108 // RenderWidgetHostView.
109 const cc::SurfaceId& local_surface_id); 109 bool TransformPointToCoordSpaceForView(const gfx::Point& point,
110 RenderWidgetHostViewBase* target_view,
111 const cc::SurfaceId& local_surface_id,
112 gfx::Point* transformed_point);
110 113
111 // Pass acked touch events to the root view for gesture processing. 114 // Pass acked touch events to the root view for gesture processing.
112 void ForwardProcessAckedTouchEvent(const TouchEventWithLatencyInfo& touch, 115 void ForwardProcessAckedTouchEvent(const TouchEventWithLatencyInfo& touch,
113 InputEventAckState ack_result); 116 InputEventAckState ack_result);
114 // Gesture events with unused scroll deltas must be bubbled to ancestors 117 // Gesture events with unused scroll deltas must be bubbled to ancestors
115 // who may consume the delta. 118 // who may consume the delta.
116 void BubbleScrollEvent(const blink::WebGestureEvent& event); 119 void BubbleScrollEvent(const blink::WebGestureEvent& event);
117 120
118 // Determines whether the root RenderWidgetHostView (and thus the current 121 // Determines whether the root RenderWidgetHostView (and thus the current
119 // page) has focus. 122 // page) has focus.
(...skipping 38 matching lines...) Expand 10 before | Expand all | Expand 10 after
158 161
159 gfx::Rect child_frame_rect_; 162 gfx::Rect child_frame_rect_;
160 163
161 bool is_scroll_bubbling_; 164 bool is_scroll_bubbling_;
162 }; 165 };
163 166
164 } // namespace content 167 } // namespace content
165 168
166 #endif // CONTENT_BROWSER_FRAME_HOST_CROSS_PROCESS_FRAME_CONNECTOR_H_ 169 #endif // CONTENT_BROWSER_FRAME_HOST_CROSS_PROCESS_FRAME_CONNECTOR_H_
167 170
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698