Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2784)

Unified Diff: chrome/browser/site_per_process_interactive_browsertest.cc

Issue 2417463003: Account for failure of coordinate space transformations in browser (Closed)
Patch Set: Review comments addressed Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/browser/frame_host/cross_process_frame_connector.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/site_per_process_interactive_browsertest.cc
diff --git a/chrome/browser/site_per_process_interactive_browsertest.cc b/chrome/browser/site_per_process_interactive_browsertest.cc
index fb4865c4d3cad8dc1228b99acb351b36ca8671ab..de70dde96691548580e283698860815035defd1a 100644
--- a/chrome/browser/site_per_process_interactive_browsertest.cc
+++ b/chrome/browser/site_per_process_interactive_browsertest.cc
@@ -388,14 +388,8 @@ void WaitForMultipleFullscreenEvents(
// - fullscreenchange events fire in both frames.
// - fullscreen CSS is applied correctly in both frames.
//
-// Flaky on Windows: https://crbug.com/647311
-#if defined(OS_WIN)
-#define MAYBE_FullscreenElementInSubframe DISABLED_FullscreenElementInSubframe
-#else
-#define MAYBE_FullscreenElementInSubframe FullscreenElementInSubframe
-#endif
IN_PROC_BROWSER_TEST_F(SitePerProcessInteractiveBrowserTest,
- MAYBE_FullscreenElementInSubframe) {
+ FullscreenElementInSubframe) {
// Start on a page with one subframe (id "child-0") that has
// "allowfullscreen" enabled.
GURL main_url(embedded_test_server()->GetURL(
@@ -588,14 +582,8 @@ void SitePerProcessInteractiveBrowserTest::FullscreenElementInABA(
EXPECT_EQ("none", GetFullscreenElementId(grandchild));
}
-// Flaky on Windows: https://crbug.com/647311
-#if defined(OS_WIN)
-#define MAYBE_FullscreenElementInABAAndExitViaEscapeKey DISABLED_FullscreenElementInABAAndExitViaEscapeKey
-#else
-#define MAYBE_FullscreenElementInABAAndExitViaEscapeKey FullscreenElementInABAAndExitViaEscapeKey
-#endif
IN_PROC_BROWSER_TEST_F(SitePerProcessInteractiveBrowserTest,
- MAYBE_FullscreenElementInABAAndExitViaEscapeKey) {
+ FullscreenElementInABAAndExitViaEscapeKey) {
FullscreenElementInABA(FullscreenExitMethod::ESC_PRESS);
}
« no previous file with comments | « no previous file | content/browser/frame_host/cross_process_frame_connector.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698