Replace FOR_EACH_OBSERVER in c/b/chromeos with range-based for

Replace FOR_EACH_OBSERVER in c/b/chromeos with range-based for

BUG=655021
TEST=try, git grep FOR_EACH_OBSERVER c/b/chromeos

Committed: https://crrev.com/7ebab277cd6641cc047072c8c8677d1408aa8e89
Cr-Commit-Position: refs/heads/master@{#425153}

[Yusuke Sato, 2016-10-13 02:31:16]

The CQ bit was checked by yusukes@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-13 02:31:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-13 02:55:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-13 02:55:47]

Dry run: This issue passed the CQ dry run.

[Yusuke Sato, 2016-10-13 05:46:39]

Description was changed from

==========
Replace FOR_EACH_OBSERVER with range-based for loops

BUG=655021
TEST=try
==========

to

==========
Replace FOR_EACH_OBSERVER in c/b/chromeos with range-based for

BUG=655021
TEST=try, git grep FOR_EACH_OBSERVER c/b/chromeos
==========

[Yusuke Sato, 2016-10-13 05:51:08]

yusukes@chromium.org changed reviewers:
+ derat@chromium.org

[Yusuke Sato, 2016-10-13 05:51:08]

Please take a look

[Daniel Erat, 2016-10-13 15:41:48]

On 2016/10/13 05:51:08, Yusuke Sato wrote:
> Please take a look

did you update these with a script that i can review, or was it manual?

[Yusuke Sato, 2016-10-13 20:21:31]

Yes, please review the following regexp. For this one, I did the following.

1. cd chromeos/ && perl -0777 -pi -e
's/FOR_EACH_OBSERVER\(\s*([\w:]+?)\s*,\s*([\w:()]+?)\s*,\s*([^;]+)\);/for (auto&
observer : \2) observer.\3;/mg' $(git gs FOR_EACH_OBSERVER | cut -d: -f1 | uniq)

The script is from
https://bugs.chromium.org/p/chromium/issues/detail?id=655021#c11 (and then
slightly modified, upstreaming my change.)

2. 'git grep FOR_EACH_OBSERVER' to make sure nothing is left.
3. git cl format
4. Manually add {} to multi-line for loops, also removed/added some whitespaces
for better git cl lint result). The diff is here: go/amffn

[Daniel Erat, 2016-10-13 20:33:44]

lgtm

thanks (especially for the diff!)

[Yusuke Sato, 2016-10-13 20:58:02]

The CQ bit was checked by yusukes@chromium.org

[commit-bot: I haz the power, 2016-10-13 20:58:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-13 21:06:41]

Description was changed from

==========
Replace FOR_EACH_OBSERVER in c/b/chromeos with range-based for

BUG=655021
TEST=try, git grep FOR_EACH_OBSERVER c/b/chromeos
==========

to

==========
Replace FOR_EACH_OBSERVER in c/b/chromeos with range-based for

BUG=655021
TEST=try, git grep FOR_EACH_OBSERVER c/b/chromeos
==========

[commit-bot: I haz the power, 2016-10-13 21:06:43]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-10-13 21:08:58]

Description was changed from

==========
Replace FOR_EACH_OBSERVER in c/b/chromeos with range-based for

BUG=655021
TEST=try, git grep FOR_EACH_OBSERVER c/b/chromeos
==========

to

==========
Replace FOR_EACH_OBSERVER in c/b/chromeos with range-based for

BUG=655021
TEST=try, git grep FOR_EACH_OBSERVER c/b/chromeos

Committed: https://crrev.com/7ebab277cd6641cc047072c8c8677d1408aa8e89
Cr-Commit-Position: refs/heads/master@{#425153}
==========

[commit-bot: I haz the power, 2016-10-13 21:09:00]

Patchset 1 (id:??) landed as
https://crrev.com/7ebab277cd6641cc047072c8c8677d1408aa8e89
Cr-Commit-Position: refs/heads/master@{#425153}