Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(707)

Unified Diff: chrome/browser/chromeos/file_manager/fake_disk_mount_manager.cc

Issue 2416763002: Replace FOR_EACH_OBSERVER in c/b/chromeos with range-based for (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/file_manager/fake_disk_mount_manager.cc
diff --git a/chrome/browser/chromeos/file_manager/fake_disk_mount_manager.cc b/chrome/browser/chromeos/file_manager/fake_disk_mount_manager.cc
index d9fe1e35fc4d9683992d060ca7c1cdd304726e1b..77f5bd9d1e7c9a597b3bb7c2319fd144d3a4d555 100644
--- a/chrome/browser/chromeos/file_manager/fake_disk_mount_manager.cc
+++ b/chrome/browser/chromeos/file_manager/fake_disk_mount_manager.cc
@@ -81,10 +81,10 @@ void FakeDiskMountManager::MountPath(const std::string& source_path,
type,
chromeos::disks::MOUNT_CONDITION_NONE);
mount_points_.insert(make_pair(source_path, mount_point));
- FOR_EACH_OBSERVER(DiskMountManager::Observer, observers_,
- OnMountEvent(DiskMountManager::MOUNTING,
- chromeos::MOUNT_ERROR_NONE,
- mount_point));
+ for (auto& observer : observers_) {
+ observer.OnMountEvent(DiskMountManager::MOUNTING,
+ chromeos::MOUNT_ERROR_NONE, mount_point);
+ }
}
void FakeDiskMountManager::UnmountPath(const std::string& mount_path,
@@ -98,10 +98,10 @@ void FakeDiskMountManager::UnmountPath(const std::string& mount_path,
const MountPointInfo mount_point = iter->second;
mount_points_.erase(iter);
- FOR_EACH_OBSERVER(DiskMountManager::Observer, observers_,
- OnMountEvent(DiskMountManager::UNMOUNTING,
- chromeos::MOUNT_ERROR_NONE,
- mount_point));
+ for (auto& observer : observers_) {
+ observer.OnMountEvent(DiskMountManager::UNMOUNTING,
+ chromeos::MOUNT_ERROR_NONE, mount_point);
+ }
// Enqueue callback so that |FakeDiskMountManager::FinishAllUnmountRequest()|
// can call them.
@@ -140,9 +140,8 @@ bool FakeDiskMountManager::AddMountPointForTest(
void FakeDiskMountManager::InvokeDiskEventForTest(
chromeos::disks::DiskMountManager::DiskEvent event,
const chromeos::disks::DiskMountManager::Disk* disk) {
- FOR_EACH_OBSERVER(chromeos::disks::DiskMountManager::Observer,
- observers_,
- OnDiskEvent(event, disk));
+ for (auto& observer : observers_)
+ observer.OnDiskEvent(event, disk);
}
} // namespace file_manager
« no previous file with comments | « chrome/browser/chromeos/drive/drive_integration_service.cc ('k') | chrome/browser/chromeos/file_manager/volume_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698