Replace FOR_EACH_OBSERVER in c/b/chromeos with range-based for

chrome/browser/chromeos/file_system_provider/request_manager.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/file_system_provider/request_manager.h"
 
 #include <utility>
 
 #include "base/files/file.h"
 #include "base/stl_util.h"
@@ skipping 55 matching lines @@
                            "RequestManager::Request",
                            request_id,
                            "type",
                            type);
 
   Request* request = new Request;
   request->handler = std::move(handler);
   requests_[request_id] = request;
   ResetTimer(request_id);
 
-  FOR_EACH_OBSERVER(Observer, observers_, OnRequestCreated(request_id, type));
+  for (auto& observer : observers_)
+    observer.OnRequestCreated(request_id, type);
 
   // Execute the request implementation. In case of an execution failure,
   // unregister and return 0. This may often happen, eg. if the providing
   // extension is not listening for the request event being sent.
   // In such case, we should abort as soon as possible.
   if (!request->handler->Execute(request_id)) {
     DestroyRequest(request_id);
     return 0;
   }
 
-  FOR_EACH_OBSERVER(Observer, observers_, OnRequestExecuted(request_id));
+  for (auto& observer : observers_)
+    observer.OnRequestExecuted(request_id);
 
   return request_id;
 }
 
 base::File::Error RequestManager::FulfillRequest(
     int request_id,
     std::unique_ptr<RequestValue> response,
     bool has_more) {
   CHECK(response.get());
   RequestMap::iterator request_it = requests_.find(request_id);
   if (request_it == requests_.end())
     return base::File::FILE_ERROR_NOT_FOUND;
 
-  FOR_EACH_OBSERVER(Observer,
-                    observers_,
-                    OnRequestFulfilled(request_id, *response.get(), has_more));
+  for (auto& observer : observers_)
+    observer.OnRequestFulfilled(request_id, *response.get(), has_more);
 
   request_it->second->handler->OnSuccess(request_id, std::move(response),
                                          has_more);
 
   if (!has_more) {
     DestroyRequest(request_id);
   } else {
     if (notification_manager_)
       notification_manager_->HideUnresponsiveNotification(request_id);
     ResetTimer(request_id);
   }
 
   return base::File::FILE_OK;
 }
 
 base::File::Error RequestManager::RejectRequest(
     int request_id,
     std::unique_ptr<RequestValue> response,
     base::File::Error error) {
   CHECK(response.get());
   RequestMap::iterator request_it = requests_.find(request_id);
   if (request_it == requests_.end())
     return base::File::FILE_ERROR_NOT_FOUND;
 
-  FOR_EACH_OBSERVER(Observer,
-                    observers_,
-                    OnRequestRejected(request_id, *response.get(), error));
+  for (auto& observer : observers_)
+    observer.OnRequestRejected(request_id, *response.get(), error);
   request_it->second->handler->OnError(request_id, std::move(response), error);
   DestroyRequest(request_id);
 
   return base::File::FILE_OK;
 }
 
 void RequestManager::SetTimeoutForTesting(const base::TimeDelta& timeout) {
   timeout_ = timeout;
 }
 
@@ skipping 17 matching lines @@
 void RequestManager::RemoveObserver(Observer* observer) {
   DCHECK(observer);
   observers_.RemoveObserver(observer);
 }
 
 RequestManager::Request::Request() {}
 
 RequestManager::Request::~Request() {}
 
 void RequestManager::OnRequestTimeout(int request_id) {
-  FOR_EACH_OBSERVER(Observer, observers_, OnRequestTimeouted(request_id));
+  for (auto& observer : observers_)
+    observer.OnRequestTimeouted(request_id);
 
   if (!notification_manager_) {
     RejectRequest(request_id, std::unique_ptr<RequestValue>(new RequestValue()),
                   base::File::FILE_ERROR_ABORT);
     return;
   }
 
   if (!IsInteractingWithUser()) {
     notification_manager_->ShowUnresponsiveNotification(
         request_id,
@@ skipping 71 matching lines @@
   RequestMap::iterator request_it = requests_.find(request_id);
   if (request_it == requests_.end())
     return;
 
   delete request_it->second;
   requests_.erase(request_it);
 
   if (notification_manager_)
     notification_manager_->HideUnresponsiveNotification(request_id);
 
-  FOR_EACH_OBSERVER(Observer, observers_, OnRequestDestroyed(request_id));
+  for (auto& observer : observers_)
+    observer.OnRequestDestroyed(request_id);
 
   TRACE_EVENT_ASYNC_END0(
       "file_system_provider", "RequestManager::Request", request_id);
 }
 
 }  // namespace file_system_provider
 }  // namespace chromeos