chrome/browser/chromeos/ownership/owner_settings_service_chromeos.cc - Issue 2416763002: Replace FOR_EACH_OBSERVER in c/b/chromeos with range-based for

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/ownership/owner_settings_service_chromeos.cc

Issue 2416763002: Replace FOR_EACH_OBSERVER in c/b/chromeos with range-based for (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/options/cert_library.cc ('k') | chrome/browser/chromeos/policy/affiliated_invalidation_service_provider_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/ownership/owner_settings_service_chromeos.cc

diff --git a/chrome/browser/chromeos/ownership/owner_settings_service_chromeos.cc b/chrome/browser/chromeos/ownership/owner_settings_service_chromeos.cc

index 0b356b4d52d3c23129bc4654545e58ef76da8882..ff2adc1fb550b51d9239b7610d941c6497c8c81e 100644

--- a/chrome/browser/chromeos/ownership/owner_settings_service_chromeos.cc

+++ b/chrome/browser/chromeos/ownership/owner_settings_service_chromeos.cc

@@ -266,8 +266,8 @@ bool OwnerSettingsServiceChromeOS::Set(const std::string& setting,

em::PolicyData policy_data;

policy_data.set_username(user_id_);

CHECK(settings.SerializeToString(policy_data.mutable_policy_value()));

- FOR_EACH_OBSERVER(OwnerSettingsService::Observer, observers_,

- OnTentativeChangesInPolicy(policy_data));

+ for (auto& observer : observers_)

+ observer.OnTentativeChangesInPolicy(policy_data);

StorePendingChanges();

return true;

}

@@ -730,8 +730,8 @@ void OwnerSettingsServiceChromeOS::OnSignedPolicyStored(bool success) {

void OwnerSettingsServiceChromeOS::ReportStatusAndContinueStoring(

bool success) {

store_settings_factory_.InvalidateWeakPtrs();

- FOR_EACH_OBSERVER(OwnerSettingsService::Observer, observers_,

- OnSignedPolicyStored(success));

+ for (auto& observer : observers_)

+ observer.OnSignedPolicyStored(success);

StorePendingChanges();

}