Replace FOR_EACH_OBSERVER in c/b/chromeos with range-based for

chrome/browser/chromeos/settings/device_settings_service.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/settings/device_settings_service.h"
 
 #include <utility>
 
 #include "base/bind.h"
 #include "base/location.h"
@@ skipping 63 matching lines @@
 
 DeviceSettingsService::DeviceSettingsService()
     : session_manager_client_(NULL),
       store_status_(STORE_SUCCESS),
       load_retries_left_(kMaxLoadRetries),
       weak_factory_(this) {
 }
 
 DeviceSettingsService::~DeviceSettingsService() {
   DCHECK(pending_operations_.empty());
-  FOR_EACH_OBSERVER(Observer, observers_, OnDeviceSettingsServiceShutdown());
+  for (auto& observer : observers_)
+    observer.OnDeviceSettingsServiceShutdown();
 }
 
 void DeviceSettingsService::SetSessionManager(
     SessionManagerClient* session_manager_client,
     scoped_refptr<OwnerKeyUtil> owner_key_util) {
   DCHECK(session_manager_client);
   DCHECK(owner_key_util.get());
   DCHECK(!session_manager_client_);
   DCHECK(!owner_key_util_.get());
 
@@ skipping 179 matching lines @@
             base::TimeDelta::FromMilliseconds(kLoadRetryDelayMs));
       } else {
         // Once we've given up retrying, the validation error is not temporary
         // anymore.
         store_status_ = STORE_VALIDATION_ERROR;
       }
     }
   }
 
   if (new_owner_key) {
-    FOR_EACH_OBSERVER(Observer, observers_, OwnershipStatusChanged());
+    for (auto& observer : observers_)
+      observer.OwnershipStatusChanged();
     content::NotificationService::current()->Notify(
         chrome::NOTIFICATION_OWNERSHIP_STATUS_CHANGED,
         content::Source<DeviceSettingsService>(this),
         content::NotificationService::NoDetails());
   }
 
-  FOR_EACH_OBSERVER(Observer, observers_, DeviceSettingsUpdated());
+  for (auto& observer : observers_)
+    observer.DeviceSettingsUpdated();
 
   std::vector<OwnershipStatusCallback> callbacks;
   callbacks.swap(pending_ownership_status_callbacks_);
   for (std::vector<OwnershipStatusCallback>::iterator iter(callbacks.begin());
        iter != callbacks.end(); ++iter) {
     iter->Run(ownership_status);
   }
 
   // The completion callback happens after the notification so clients can
   // filter self-triggered updates.
   if (!callback.is_null())
     callback.Run();
 
   // Only remove the pending operation here, so new operations triggered by any
   // of the callbacks above are queued up properly.
   pending_operations_.pop_front();
 
   StartNextOperation();
 }
 
 void DeviceSettingsService::HandleError(Status status,
                                         const base::Closure& callback) {
   store_status_ = status;
 
   LOG(ERROR) << "Session manager operation failed: " << status;
 
-  FOR_EACH_OBSERVER(Observer, observers_, DeviceSettingsUpdated());
+  for (auto& observer : observers_)
+    observer.DeviceSettingsUpdated();
 
   // The completion callback happens after the notification so clients can
   // filter self-triggered updates.
   if (!callback.is_null())
     callback.Run();
 }
 
 ScopedTestDeviceSettingsService::ScopedTestDeviceSettingsService() {
   DeviceSettingsService::Initialize();
 }
 
 ScopedTestDeviceSettingsService::~ScopedTestDeviceSettingsService() {
   // Clean pending operations.
   DeviceSettingsService::Get()->UnsetSessionManager();
   DeviceSettingsService::Shutdown();
 }
 
 }  // namespace chromeos