Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Issue 2410343002: [Reland] Add gl tests to make sure when a buffer is unmapped, all access path generates an INVALID_… (Closed)

Created:
4 years, 2 months ago by Zhenyao Mo
Modified:
4 years, 2 months ago
Reviewers:
vmiura
CC:
chromium-reviews, piman+watch_chromium.org, Ken Russell (switch to Gerrit), Kai Ninomiya, Corentin Wallez
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Reland] Add gl tests to make sure when a buffer is unmapped, all access path generates an INVALID_OPERATION. Original reviewed CL: http://crrev.com/2399113003#ps60001 Reverted in https://codereview.chromium.org/2410023002/ BUG=429053, 654709 TEST=gl_tests R=vmiura@chromium.org patch from issue 2399113003 at patchset 60001 () CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/444e085edc12c25ef74e34c5b259667fcfeb81f3 Cr-Commit-Position: refs/heads/master@{#424630}

Patch Set 1 : Original reviewed CL #

Patch Set 2 : Skip the test if context creation fails. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+569 lines, -124 lines) Patch
M gpu/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 5 chunks +73 lines, -12 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest.cc View 1 chunk +0 lines, -61 lines 0 comments Download
M gpu/command_buffer/service/program_manager.h View 2 chunks +10 lines, -5 lines 0 comments Download
M gpu/command_buffer/service/program_manager.cc View 3 chunks +6 lines, -2 lines 0 comments Download
M gpu/command_buffer/service/program_manager_unittest.cc View 4 chunks +22 lines, -27 lines 0 comments Download
M gpu/command_buffer/service/transform_feedback_manager.h View 1 chunk +0 lines, -2 lines 0 comments Download
M gpu/command_buffer/service/transform_feedback_manager.cc View 1 chunk +0 lines, -7 lines 0 comments Download
A gpu/command_buffer/tests/gl_map_buffer_range_unittest.cc View 1 1 chunk +434 lines, -0 lines 0 comments Download
M gpu/command_buffer/tests/gl_program_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M gpu/command_buffer/tests/gl_test_utils.h View 2 chunks +6 lines, -0 lines 0 comments Download
M gpu/command_buffer/tests/gl_test_utils.cc View 2 chunks +17 lines, -7 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 23 (13 generated)
Zhenyao Mo
vmiura: please review the diff between patchset 1 and 2. Others: FYI (feel free to ...
4 years, 2 months ago (2016-10-11 20:53:58 UTC) #5
Zhenyao Mo
On 2016/10/11 20:53:58, Zhenyao Mo wrote: > vmiura: please review the diff between patchset 1 ...
4 years, 2 months ago (2016-10-11 20:56:18 UTC) #6
vmiura
On 2016/10/11 20:56:18, Zhenyao Mo wrote: > On 2016/10/11 20:53:58, Zhenyao Mo wrote: > > ...
4 years, 2 months ago (2016-10-12 00:18:37 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2410343002/20001
4 years, 2 months ago (2016-10-12 00:20:13 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/builds/85131)
4 years, 2 months ago (2016-10-12 00:34:04 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2410343002/20001
4 years, 2 months ago (2016-10-12 00:40:41 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/builds/85145)
4 years, 2 months ago (2016-10-12 00:52:56 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2410343002/20001
4 years, 2 months ago (2016-10-12 01:02:24 UTC) #19
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-12 01:19:57 UTC) #21
commit-bot: I haz the power
4 years, 2 months ago (2016-10-12 01:23:11 UTC) #23
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/444e085edc12c25ef74e34c5b259667fcfeb81f3
Cr-Commit-Position: refs/heads/master@{#424630}

Powered by Google App Engine
This is Rietveld 408576698