Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Unified Diff: gpu/command_buffer/service/program_manager.h

Issue 2410343002: [Reland] Add gl tests to make sure when a buffer is unmapped, all access path generates an INVALID_… (Closed)
Patch Set: Skip the test if context creation fails. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: gpu/command_buffer/service/program_manager.h
diff --git a/gpu/command_buffer/service/program_manager.h b/gpu/command_buffer/service/program_manager.h
index e65c65bb6ba50a07f94ae69f515d32c139a9e4ec..cec21a96e4b75f0e3f287e14fcdbdf09436f3129 100644
--- a/gpu/command_buffer/service/program_manager.h
+++ b/gpu/command_buffer/service/program_manager.h
@@ -387,12 +387,13 @@ class GPU_EXPORT Program : public base::RefCounted<Program> {
return bind_attrib_location_map_;
}
- const std::vector<std::string>& transform_feedback_varyings() const {
- return transform_feedback_varyings_;
+ const std::vector<std::string>& effective_transform_feedback_varyings()
+ const {
+ return effective_transform_feedback_varyings_;
}
- GLenum transform_feedback_buffer_mode() const {
- return transform_feedback_buffer_mode_;
+ GLenum effective_transform_feedback_buffer_mode() const {
+ return effective_transform_feedback_buffer_mode_;
}
// See member declaration for details.
@@ -554,10 +555,14 @@ class GPU_EXPORT Program : public base::RefCounted<Program> {
// uniform-location binding map from glBindUniformLocationCHROMIUM() calls.
LocationMap bind_uniform_location_map_;
+ // Set by glTransformFeedbackVaryings().
std::vector<std::string> transform_feedback_varyings_;
-
GLenum transform_feedback_buffer_mode_;
+ // After a successful link.
+ std::vector<std::string> effective_transform_feedback_varyings_;
+ GLenum effective_transform_feedback_buffer_mode_;
+
// Fragment input-location binding map from
// glBindFragmentInputLocationCHROMIUM() calls.
LocationMap bind_fragment_input_location_map_;
« no previous file with comments | « gpu/command_buffer/service/gles2_cmd_decoder_unittest.cc ('k') | gpu/command_buffer/service/program_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698