Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Issue 2408913002: Push hasValidAttributeName/Type down into SVGAnimateElement (Closed)

Created:
4 years, 2 months ago by fs
Modified:
4 years, 2 months ago
Reviewers:
pdr.
CC:
fs, darktears, blink-reviews, blink-reviews-animation_chromium.org, chromium-reviews, krit, Eric Willigers, f(malita), gyuyoung2, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, rjwright, rwlbuis, Stephen Chennney, shans
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Push hasValidAttributeName/Type down into SVGAnimateElement Introduce a new "validator" method for SVGSMILElements - hasValidTarget. With this new method in place, the hasValidAttributeType and hasValidAttributeName methods can be pushed down the hierarchy to where they belong, namely SVGAnimateElement. As a bonus, some conditions and assertions can be simplified. BUG=641437 Committed: https://crrev.com/1d1019a5021c6668d1195e34f2aa081eab2241c8 Cr-Commit-Position: refs/heads/master@{#424389}

Patch Set 1 #

Messages

Total messages: 12 (7 generated)
fs
4 years, 2 months ago (2016-10-10 22:13:48 UTC) #4
pdr.
On 2016/10/10 at 22:13:48, fs wrote: > LGTM
4 years, 2 months ago (2016-10-10 22:20:40 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2408913002/1
4 years, 2 months ago (2016-10-11 08:08:34 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-11 08:14:30 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-10-11 08:16:35 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1d1019a5021c6668d1195e34f2aa081eab2241c8
Cr-Commit-Position: refs/heads/master@{#424389}

Powered by Google App Engine
This is Rietveld 408576698