Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(556)

Side by Side Diff: third_party/WebKit/Source/core/svg/SVGAnimateElement.h

Issue 2408913002: Push hasValidAttributeName/Type down into SVGAnimateElement (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/svg/SVGAnimateElement.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004, 2005 Nikolas Zimmermann <zimmermann@kde.org> 2 * Copyright (C) 2004, 2005 Nikolas Zimmermann <zimmermann@kde.org>
3 * Copyright (C) 2004, 2005 Rob Buis <buis@kde.org> 3 * Copyright (C) 2004, 2005 Rob Buis <buis@kde.org>
4 * Copyright (C) 2008 Apple Inc. All rights reserved. 4 * Copyright (C) 2008 Apple Inc. All rights reserved.
5 * Copyright (C) Research In Motion Limited 2011. All rights reserved. 5 * Copyright (C) Research In Motion Limited 2011. All rights reserved.
6 * 6 *
7 * This library is free software; you can redistribute it and/or 7 * This library is free software; you can redistribute it and/or
8 * modify it under the terms of the GNU Library General Public 8 * modify it under the terms of the GNU Library General Public
9 * License as published by the Free Software Foundation; either 9 * License as published by the Free Software Foundation; either
10 * version 2 of the License, or (at your option) any later version. 10 * version 2 of the License, or (at your option) any later version.
(...skipping 87 matching lines...) Expand 10 before | Expand all | Expand 10 after
98 ShouldApplyAnimationType shouldApplyAnimation( 98 ShouldApplyAnimationType shouldApplyAnimation(
99 SVGElement* targetElement, 99 SVGElement* targetElement,
100 const QualifiedName& attributeName); 100 const QualifiedName& attributeName);
101 101
102 void setAttributeType(const AtomicString&); 102 void setAttributeType(const AtomicString&);
103 103
104 void checkInvalidCSSAttributeType(); 104 void checkInvalidCSSAttributeType();
105 bool hasInvalidCSSAttributeType() const { 105 bool hasInvalidCSSAttributeType() const {
106 return m_hasInvalidCSSAttributeType; 106 return m_hasInvalidCSSAttributeType;
107 } 107 }
108 bool hasValidAttributeType() override; 108 bool hasValidTarget() final;
109 bool hasValidAttributeName() const;
110 virtual bool hasValidAttributeType();
109 111
110 SVGPropertyBase* adjustForInheritance(SVGPropertyBase*, 112 SVGPropertyBase* adjustForInheritance(SVGPropertyBase*,
111 AnimatedPropertyValueType) const; 113 AnimatedPropertyValueType) const;
112 114
113 Member<SVGPropertyBase> m_fromProperty; 115 Member<SVGPropertyBase> m_fromProperty;
114 Member<SVGPropertyBase> m_toProperty; 116 Member<SVGPropertyBase> m_toProperty;
115 Member<SVGPropertyBase> m_toAtEndOfDurationProperty; 117 Member<SVGPropertyBase> m_toAtEndOfDurationProperty;
116 Member<SVGPropertyBase> m_animatedProperty; 118 Member<SVGPropertyBase> m_animatedProperty;
117 119
118 SVGAnimatedTypeAnimator m_animator; 120 SVGAnimatedTypeAnimator m_animator;
119 121
120 AnimatedPropertyValueType m_fromPropertyValueType; 122 AnimatedPropertyValueType m_fromPropertyValueType;
121 AnimatedPropertyValueType m_toPropertyValueType; 123 AnimatedPropertyValueType m_toPropertyValueType;
122 AttributeType m_attributeType; 124 AttributeType m_attributeType;
123 bool m_hasInvalidCSSAttributeType; 125 bool m_hasInvalidCSSAttributeType;
124 }; 126 };
125 127
126 inline bool isSVGAnimateElement(const SVGElement& element) { 128 inline bool isSVGAnimateElement(const SVGElement& element) {
127 return element.hasTagName(SVGNames::animateTag) || 129 return element.hasTagName(SVGNames::animateTag) ||
128 element.hasTagName(SVGNames::animateTransformTag) || 130 element.hasTagName(SVGNames::animateTransformTag) ||
129 element.hasTagName(SVGNames::setTag); 131 element.hasTagName(SVGNames::setTag);
130 } 132 }
131 133
132 DEFINE_SVGELEMENT_TYPE_CASTS_WITH_FUNCTION(SVGAnimateElement); 134 DEFINE_SVGELEMENT_TYPE_CASTS_WITH_FUNCTION(SVGAnimateElement);
133 135
134 } // namespace blink 136 } // namespace blink
135 137
136 #endif // SVGAnimateElement_h 138 #endif // SVGAnimateElement_h
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/svg/SVGAnimateElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698