third_party/WebKit/Source/core/svg/animation/SVGSMILElement.h - Issue 2408913002: Push hasValidAttributeName/Type down into SVGAnimateElement

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/svg/animation/SVGSMILElement.h

Issue 2408913002: Push hasValidAttributeName/Type down into SVGAnimateElement (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/svg/animation/SVGSMILElement.h

diff --git a/third_party/WebKit/Source/core/svg/animation/SVGSMILElement.h b/third_party/WebKit/Source/core/svg/animation/SVGSMILElement.h

index 826f30cc1366e00fd42ff621e87785adbb4d8824..2db1707b69092fdc4347dd732c457bf7ddb85ff5 100644

--- a/third_party/WebKit/Source/core/svg/animation/SVGSMILElement.h

+++ b/third_party/WebKit/Source/core/svg/animation/SVGSMILElement.h

@@ -55,8 +55,7 @@ class CORE_EXPORT SVGSMILElement : public SVGElement, public SVGTests {

InsertionNotificationRequest insertedInto(ContainerNode*) override;

void removedFrom(ContainerNode*) override;

- virtual bool hasValidAttributeType() = 0;

- virtual bool hasValidAttributeName();

+ virtual bool hasValidTarget();

virtual void animationAttributeChanged() = 0;

SMILTimeContainer* timeContainer() const { return m_timeContainer.get(); }