third_party/WebKit/Source/core/svg/SVGAnimationElement.cpp - Issue 2408913002: Push hasValidAttributeName/Type down into SVGAnimateElement

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/svg/SVGAnimationElement.cpp

Issue 2408913002: Push hasValidAttributeName/Type down into SVGAnimateElement (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/svg/SVGAnimationElement.cpp

diff --git a/third_party/WebKit/Source/core/svg/SVGAnimationElement.cpp b/third_party/WebKit/Source/core/svg/SVGAnimationElement.cpp

index f8b993764eec2eb1449a9334d9b296a7fd61e86e..8f7c47a67d644e609ce507c553eb6b29a4343b96 100644

--- a/third_party/WebKit/Source/core/svg/SVGAnimationElement.cpp

+++ b/third_party/WebKit/Source/core/svg/SVGAnimationElement.cpp

@@ -518,11 +518,7 @@ void SVGAnimationElement::currentValuesForValuesAnimation(

void SVGAnimationElement::startedActiveInterval() {

m_animationValid = false;

- if (!isValid())

- return;

- if (!targetElement())

- return;

- if (!hasValidAttributeType())

+ if (!isValid() || !hasValidTarget())

return;

// These validations are appropriate for all animation modes.