Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Unified Diff: third_party/WebKit/Source/core/svg/animation/SMILTimeContainer.cpp

Issue 2408913002: Push hasValidAttributeName/Type down into SVGAnimateElement (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/svg/animation/SMILTimeContainer.cpp
diff --git a/third_party/WebKit/Source/core/svg/animation/SMILTimeContainer.cpp b/third_party/WebKit/Source/core/svg/animation/SMILTimeContainer.cpp
index b4e354f0b609f60fef973184c5c2dedfc0544eac..4283784b75c432b5368849d34d02915032f5e465 100644
--- a/third_party/WebKit/Source/core/svg/animation/SMILTimeContainer.cpp
+++ b/third_party/WebKit/Source/core/svg/animation/SMILTimeContainer.cpp
@@ -71,11 +71,9 @@ SMILTimeContainer::~SMILTimeContainer() {
void SMILTimeContainer::schedule(SVGSMILElement* animation,
SVGElement* target,
const QualifiedName& attributeName) {
- ASSERT(animation->timeContainer() == this);
- ASSERT(target);
- ASSERT(animation->hasValidAttributeName());
- ASSERT(animation->hasValidAttributeType());
- ASSERT(animation->inActiveDocument());
+ DCHECK_EQ(animation->timeContainer(), this);
+ DCHECK(target);
+ DCHECK(animation->hasValidTarget());
#if ENABLE(ASSERT)
ASSERT(!m_preventScheduledAnimationsChanges);
@@ -458,10 +456,8 @@ SMILTime SMILTimeContainer::updateAnimations(double elapsed, bool seekToTime) {
AnimationsVector sandwich;
for (const auto& itAnimation : scheduledAnimationsInSameGroup) {
SVGSMILElement* animation = itAnimation.get();
- ASSERT(animation->timeContainer() == this);
- ASSERT(animation->targetElement());
- ASSERT(animation->hasValidAttributeName());
- ASSERT(animation->hasValidAttributeType());
+ DCHECK_EQ(animation->timeContainer(), this);
+ DCHECK(animation->hasValidTarget());
// This will calculate the contribution from the animation and update
// timing.

Powered by Google App Engine
This is Rietveld 408576698