DevTools: teach network UISourceCodes to return metadata

DevTools: teach network UISourceCodes to return metadata

The patch teaches network-based UISourceCodes to return non-null
metadata.

For the resource-based UISourceCodes, the metadata simply comes
from the underlying resource.

For the sourcemap-originating UISourceCodes which content was
embedded in the sourcemap, the contentSize metadata is available.

Drive-By: improve complexity of WI.ResourceTreeModel.resourceForURL
from O(|resources|) to O(|frames|).

BUG=none

Committed: https://crrev.com/a22a11e3879975ab54daa514193934e4b32a966e
Cr-Commit-Position: refs/heads/master@{#425540}

[lushnikov, 2016-10-14 06:58:40]

The CQ bit was checked by lushnikov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-14 06:58:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-14 08:22:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-14 08:22:12]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[lushnikov, 2016-10-14 21:15:35]

Description was changed from

==========
DevTools: teach network UISourceCodes to return metadata

The patch teaches network-based UISourceCodes to return non-null
metadata.

For the resource-based UISourceCodes, the metadata simply comes
from the underlying resource.

For the sourcemap-originating UISourceCodes which content was
inlined in the sourcemap, the contentSize metadata is set.

BUG=none
==========

to

==========
DevTools: teach network UISourceCodes to return metadata

The patch teaches network-based UISourceCodes to return non-null
metadata.

For the resource-based UISourceCodes, the metadata simply comes
from the underlying resource.

For the sourcemap-originating UISourceCodes which content was
embedded in the sourcemap, the contentSize metadata is available.

BUG=none
==========

[lushnikov, 2016-10-14 21:18:02]

Description was changed from

==========
DevTools: teach network UISourceCodes to return metadata

The patch teaches network-based UISourceCodes to return non-null
metadata.

For the resource-based UISourceCodes, the metadata simply comes
from the underlying resource.

For the sourcemap-originating UISourceCodes which content was
embedded in the sourcemap, the contentSize metadata is available.

BUG=none
==========

to

==========
DevTools: teach network UISourceCodes to return metadata

The patch teaches network-based UISourceCodes to return non-null
metadata.

For the resource-based UISourceCodes, the metadata simply comes
from the underlying resource.

For the sourcemap-originating UISourceCodes which content was
embedded in the sourcemap, the contentSize metadata is available.

Drive-By: make WI.ResourceTreeModel.resourceForURL work
O(|frames|) instead of O(|resources|).

BUG=none
==========

[lushnikov, 2016-10-14 21:18:51]

Description was changed from

==========
DevTools: teach network UISourceCodes to return metadata

The patch teaches network-based UISourceCodes to return non-null
metadata.

For the resource-based UISourceCodes, the metadata simply comes
from the underlying resource.

For the sourcemap-originating UISourceCodes which content was
embedded in the sourcemap, the contentSize metadata is available.

Drive-By: make WI.ResourceTreeModel.resourceForURL work
O(|frames|) instead of O(|resources|).

BUG=none
==========

to

==========
DevTools: teach network UISourceCodes to return metadata

The patch teaches network-based UISourceCodes to return non-null
metadata.

For the resource-based UISourceCodes, the metadata simply comes
from the underlying resource.

For the sourcemap-originating UISourceCodes which content was
embedded in the sourcemap, the contentSize metadata is available.

Drive-By: improve complexity of WI.ResourceTreeModel.resourceForURL
from O(|resources|) to O(|frames|).

BUG=none
==========

[lushnikov, 2016-10-14 21:30:32]

lushnikov@chromium.org changed reviewers:
+ dgozman@chromium.org

[lushnikov, 2016-10-14 21:30:32]

please, take a look

[lushnikov, 2016-10-14 21:30:40]

The CQ bit was checked by lushnikov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-14 21:31:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dgozman, 2016-10-14 21:49:21]

lgtm

https://codereview.chromium.org/2408203007/diff/80001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/devtools/front_end/bindings/ContentProviderBasedProject.js
(right):

https://codereview.chromium.org/2408203007/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/bindings/ContentProviderBasedProject.js:285:
uiSourceCode[WebInspector.ContentProviderBasedProject._metadata] = metadata ||
null;
nit: no need for || null

https://codereview.chromium.org/2408203007/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/bindings/ContentProviderBasedProject.js:294:
addContentProvider: function(url, contentProvider)
Why no metadata here?

https://codereview.chromium.org/2408203007/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/sdk/ResourceTreeModel.js
(right):

https://codereview.chromium.org/2408203007/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sdk/ResourceTreeModel.js:730: var
resource = this._resourcesMap[url];
|| null

[lushnikov, 2016-10-14 22:46:39]

https://codereview.chromium.org/2408203007/diff/80001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/devtools/front_end/bindings/ContentProviderBasedProject.js
(right):

https://codereview.chromium.org/2408203007/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/bindings/ContentProviderBasedProject.js:285:
uiSourceCode[WebInspector.ContentProviderBasedProject._metadata] = metadata ||
null;
On 2016/10/14 21:49:20, dgozman wrote:
> nit: no need for || null

Done.

https://codereview.chromium.org/2408203007/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/bindings/ContentProviderBasedProject.js:294:
addContentProvider: function(url, contentProvider)
On 2016/10/14 21:49:20, dgozman wrote:
> Why no metadata here?

This method doesn't have any clients who're interested in passing metadata.
As far as a need emerges, we'll plumb metadata here!

https://codereview.chromium.org/2408203007/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/sdk/ResourceTreeModel.js
(right):

https://codereview.chromium.org/2408203007/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sdk/ResourceTreeModel.js:730: var
resource = this._resourcesMap[url];
On 2016/10/14 21:49:20, dgozman wrote:
> || null

Done.

[lushnikov, 2016-10-14 22:46:46]

The CQ bit was checked by lushnikov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-14 22:47:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[lushnikov, 2016-10-15 00:18:18]

The CQ bit was unchecked by lushnikov@chromium.org

[lushnikov, 2016-10-15 00:18:19]

The CQ bit was checked by lushnikov@chromium.org

[lushnikov, 2016-10-15 00:18:19]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2408203007/#ps100001
(title: "address comments")

[commit-bot: I haz the power, 2016-10-15 00:18:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-15 02:49:16]

Description was changed from

==========
DevTools: teach network UISourceCodes to return metadata

The patch teaches network-based UISourceCodes to return non-null
metadata.

For the resource-based UISourceCodes, the metadata simply comes
from the underlying resource.

For the sourcemap-originating UISourceCodes which content was
embedded in the sourcemap, the contentSize metadata is available.

Drive-By: improve complexity of WI.ResourceTreeModel.resourceForURL
from O(|resources|) to O(|frames|).

BUG=none
==========

to

==========
DevTools: teach network UISourceCodes to return metadata

The patch teaches network-based UISourceCodes to return non-null
metadata.

For the resource-based UISourceCodes, the metadata simply comes
from the underlying resource.

For the sourcemap-originating UISourceCodes which content was
embedded in the sourcemap, the contentSize metadata is available.

Drive-By: improve complexity of WI.ResourceTreeModel.resourceForURL
from O(|resources|) to O(|frames|).

BUG=none
==========

[commit-bot: I haz the power, 2016-10-15 02:49:17]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-10-15 02:50:47]

Description was changed from

==========
DevTools: teach network UISourceCodes to return metadata

The patch teaches network-based UISourceCodes to return non-null
metadata.

For the resource-based UISourceCodes, the metadata simply comes
from the underlying resource.

For the sourcemap-originating UISourceCodes which content was
embedded in the sourcemap, the contentSize metadata is available.

Drive-By: improve complexity of WI.ResourceTreeModel.resourceForURL
from O(|resources|) to O(|frames|).

BUG=none
==========

to

==========
DevTools: teach network UISourceCodes to return metadata

The patch teaches network-based UISourceCodes to return non-null
metadata.

For the resource-based UISourceCodes, the metadata simply comes
from the underlying resource.

For the sourcemap-originating UISourceCodes which content was
embedded in the sourcemap, the contentSize metadata is available.

Drive-By: improve complexity of WI.ResourceTreeModel.resourceForURL
from O(|resources|) to O(|frames|).

BUG=none

Committed: https://crrev.com/a22a11e3879975ab54daa514193934e4b32a966e
Cr-Commit-Position: refs/heads/master@{#425540}
==========

[commit-bot: I haz the power, 2016-10-15 02:50:48]

Patchset 6 (id:??) landed as
https://crrev.com/a22a11e3879975ab54daa514193934e4b32a966e
Cr-Commit-Position: refs/heads/master@{#425540}