third_party/WebKit/Source/devtools/front_end/bindings/SASSSourceMapping.js - Issue 2408203007: DevTools: teach network UISourceCodes to return metadata

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/bindings/SASSSourceMapping.js

Issue 2408203007: DevTools: teach network UISourceCodes to return metadata (Closed)

Patch Set: address comments Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/bindings/NetworkProject.js ('k') | third_party/WebKit/Source/devtools/front_end/sass/ASTSourceMap.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/bindings/SASSSourceMapping.js

diff --git a/third_party/WebKit/Source/devtools/front_end/bindings/SASSSourceMapping.js b/third_party/WebKit/Source/devtools/front_end/bindings/SASSSourceMapping.js

index f0564467522d2e1920ebec357fbf9af9750b1b9d..ec0c7f186582c665111bdf5d84f43a1116f3dbb3 100644

--- a/third_party/WebKit/Source/devtools/front_end/bindings/SASSSourceMapping.js

+++ b/third_party/WebKit/Source/devtools/front_end/bindings/SASSSourceMapping.js

@@ -56,7 +56,9 @@ WebInspector.SASSSourceMapping.prototype = {

var sourceMap = this._cssModel.sourceMapForHeader(header);

for (var sassURL of sourceMap.sourceURLs()) {

var contentProvider = sourceMap.sourceContentProvider(sassURL, WebInspector.resourceTypes.SourceMapStyleSheet);

- this._networkProject.addFile(contentProvider, WebInspector.ResourceTreeFrame.fromStyleSheet(header));

+ var embeddedContent = sourceMap.embeddedContentByURL(sassURL);

+ var embeddedContentLength = typeof embeddedContent === "string" ? embeddedContent.length : null;

+ this._networkProject.addFile(contentProvider, WebInspector.ResourceTreeFrame.fromStyleSheet(header), false, embeddedContentLength);

}

WebInspector.cssWorkspaceBinding.updateLocations(header);