Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Unified Diff: third_party/WebKit/Source/devtools/front_end/bindings/ContentProviderBasedProject.js

Issue 2408203007: DevTools: teach network UISourceCodes to return metadata (Closed)
Patch Set: address comments Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/bindings/ContentProviderBasedProject.js
diff --git a/third_party/WebKit/Source/devtools/front_end/bindings/ContentProviderBasedProject.js b/third_party/WebKit/Source/devtools/front_end/bindings/ContentProviderBasedProject.js
index d62fb0ef5e73d12dd8af04e0f29c676a3a9a6621..16599a2e8230fd3e57d0f4c4c321dd663d702259 100644
--- a/third_party/WebKit/Source/devtools/front_end/bindings/ContentProviderBasedProject.js
+++ b/third_party/WebKit/Source/devtools/front_end/bindings/ContentProviderBasedProject.js
@@ -45,6 +45,8 @@ WebInspector.ContentProviderBasedProject = function(workspace, id, type, display
workspace.addProject(this);
}
+WebInspector.ContentProviderBasedProject._metadata = Symbol("ContentProviderBasedProject.Metadata");
+
WebInspector.ContentProviderBasedProject.prototype = {
/**
* @override
@@ -64,7 +66,7 @@ WebInspector.ContentProviderBasedProject.prototype = {
*/
requestMetadata: function(uiSourceCode)
{
- return Promise.resolve(/** @type {?WebInspector.UISourceCodeMetadata} */(null));
+ return Promise.resolve(uiSourceCode[WebInspector.ContentProviderBasedProject._metadata]);
},
/**
@@ -275,10 +277,12 @@ WebInspector.ContentProviderBasedProject.prototype = {
/**
* @param {!WebInspector.UISourceCode} uiSourceCode
* @param {!WebInspector.ContentProvider} contentProvider
+ * @param {?WebInspector.UISourceCodeMetadata} metadata
*/
- addUISourceCodeWithProvider: function(uiSourceCode, contentProvider)
+ addUISourceCodeWithProvider: function(uiSourceCode, contentProvider, metadata)
{
this._contentProviders[uiSourceCode.url()] = contentProvider;
+ uiSourceCode[WebInspector.ContentProviderBasedProject._metadata] = metadata;
this.addUISourceCode(uiSourceCode, true);
},
@@ -290,7 +294,7 @@ WebInspector.ContentProviderBasedProject.prototype = {
addContentProvider: function(url, contentProvider)
{
var uiSourceCode = this.createUISourceCode(url, contentProvider.contentType());
- this.addUISourceCodeWithProvider(uiSourceCode, contentProvider);
+ this.addUISourceCodeWithProvider(uiSourceCode, contentProvider, null);
return uiSourceCode;
},

Powered by Google App Engine
This is Rietveld 408576698