third_party/WebKit/Source/devtools/front_end/bindings/CompilerScriptMapping.js - Issue 2408203007: DevTools: teach network UISourceCodes to return metadata

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/bindings/CompilerScriptMapping.js

Issue 2408203007: DevTools: teach network UISourceCodes to return metadata (Closed)

Patch Set: address comments Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/inspector/sources/ui-source-code-metadata-expected.txt ('k') | third_party/WebKit/Source/devtools/front_end/bindings/ContentProviderBasedProject.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/bindings/CompilerScriptMapping.js

diff --git a/third_party/WebKit/Source/devtools/front_end/bindings/CompilerScriptMapping.js b/third_party/WebKit/Source/devtools/front_end/bindings/CompilerScriptMapping.js

index b107648fb2b04471139c6304c5ed06a781a2f0a9..23034700bbde7151cf239405b285bb6110c2a6ca 100644

--- a/third_party/WebKit/Source/devtools/front_end/bindings/CompilerScriptMapping.js

+++ b/third_party/WebKit/Source/devtools/front_end/bindings/CompilerScriptMapping.js

@@ -237,7 +237,9 @@ WebInspector.CompilerScriptMapping.prototype = {

var uiSourceCode = this._networkMapping.uiSourceCodeForScriptURL(sourceURL, script);

if (!uiSourceCode) {

var contentProvider = sourceMap.sourceContentProvider(sourceURL, WebInspector.resourceTypes.SourceMapScript);

- uiSourceCode = this._networkProject.addFile(contentProvider, WebInspector.ResourceTreeFrame.fromScript(script), script.isContentScript());

+ var embeddedContent = sourceMap.embeddedContentByURL(sourceURL);

+ var embeddedContentLength = typeof embeddedContent === "string" ? embeddedContent.length : null;

+ uiSourceCode = this._networkProject.addFile(contentProvider, WebInspector.ResourceTreeFrame.fromScript(script), script.isContentScript(), embeddedContentLength);

uiSourceCode[WebInspector.CompilerScriptMapping._originSymbol] = script.sourceURL;

}

if (uiSourceCode) {