DevTools: introduce WI.Resource.contentSize() and WI.Resource.lastModified()

DevTools: introduce WI.Resource.contentSize() and WI.Resource.lastModified()

The patch adds contentSize() and lastModified() methods to the WI.Resource.

The WI.Resource gets the data either from the resource payload or from
the attached request, if any.

BUG=none

Committed: https://crrev.com/bdb833dea5283a3017b7d291ce984317a4c34905
Cr-Commit-Position: refs/heads/master@{#425508}

[lushnikov, 2016-10-14 05:39:24]

lushnikov@chromium.org changed reviewers:
+ dgozman@chromium.org, pfeldman@chromium.org

[lushnikov, 2016-10-14 05:39:25]

Please, take a look

[lushnikov, 2016-10-14 05:40:08]

Description was changed from

==========
DevTools: WI.Resource to have contentSize and lastModified

The patch adds contentSize() and lastModified() methods to the WI.Resource.

The WI.Resource gets the data either from the resource payload or from
the attached request, if any.

BUG=none
==========

to

==========
DevTools: introduce WI.Resource.contentSize() and WI.Resource.lastModified()

The patch adds contentSize() and lastModified() methods to the WI.Resource.

The WI.Resource gets the data either from the resource payload or from
the attached request, if any.

BUG=none
==========

[lushnikov, 2016-10-14 05:40:38]

The CQ bit was checked by lushnikov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-14 05:40:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-14 07:44:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-14 07:44:50]

Dry run: This issue passed the CQ dry run.

[dgozman, 2016-10-14 18:48:51]

lgtm

https://codereview.chromium.org/2413233003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/sdk/Resource.js (right):

https://codereview.chromium.org/2413233003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sdk/Resource.js:41: * @param
{?number} lastModified
Let's pass ?Date instead.

[lushnikov, 2016-10-14 20:56:28]

Also, added forgotten Date validation on the Resource level

https://codereview.chromium.org/2413233003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/sdk/Resource.js (right):

https://codereview.chromium.org/2413233003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sdk/Resource.js:41: * @param
{?number} lastModified
On 2016/10/14 18:48:51, dgozman wrote:
> Let's pass ?Date instead.

Done.

[lushnikov, 2016-10-14 21:04:51]

The CQ bit was checked by lushnikov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-14 21:05:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[lushnikov, 2016-10-14 22:20:48]

The CQ bit was unchecked by lushnikov@chromium.org

[lushnikov, 2016-10-14 22:20:53]

The CQ bit was checked by lushnikov@chromium.org

[lushnikov, 2016-10-14 22:20:54]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2413233003/#ps80001
(title: "always send last-modified in php script")

[commit-bot: I haz the power, 2016-10-14 22:21:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-14 23:30:42]

Description was changed from

==========
DevTools: introduce WI.Resource.contentSize() and WI.Resource.lastModified()

The patch adds contentSize() and lastModified() methods to the WI.Resource.

The WI.Resource gets the data either from the resource payload or from
the attached request, if any.

BUG=none
==========

to

==========
DevTools: introduce WI.Resource.contentSize() and WI.Resource.lastModified()

The patch adds contentSize() and lastModified() methods to the WI.Resource.

The WI.Resource gets the data either from the resource payload or from
the attached request, if any.

BUG=none
==========

[commit-bot: I haz the power, 2016-10-14 23:30:43]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-10-14 23:33:14]

Description was changed from

==========
DevTools: introduce WI.Resource.contentSize() and WI.Resource.lastModified()

The patch adds contentSize() and lastModified() methods to the WI.Resource.

The WI.Resource gets the data either from the resource payload or from
the attached request, if any.

BUG=none
==========

to

==========
DevTools: introduce WI.Resource.contentSize() and WI.Resource.lastModified()

The patch adds contentSize() and lastModified() methods to the WI.Resource.

The WI.Resource gets the data either from the resource payload or from
the attached request, if any.

BUG=none

Committed: https://crrev.com/bdb833dea5283a3017b7d291ce984317a4c34905
Cr-Commit-Position: refs/heads/master@{#425508}
==========

[commit-bot: I haz the power, 2016-10-14 23:33:15]

Patchset 5 (id:??) landed as
https://crrev.com/bdb833dea5283a3017b7d291ce984317a4c34905
Cr-Commit-Position: refs/heads/master@{#425508}