Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(463)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2408193002: Revert of Turned on SkSL->GLSL compiler (Closed)

Created:
4 years, 2 months ago by jvanverth1
Modified:
4 years, 2 months ago
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Turned on SkSL->GLSL compiler (patchset #49 id:1240001 of https://codereview.chromium.org/2288033003/ ) Reason for revert: Pre-emptive revert. Sorry, but we're getting back up on our roll and Chrome reverted our last one for apparently no reason. Original issue's description: > Turned on SkSL->GLSL compiler > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2288033003 > > Committed: https://skia.googlesource.com/skia/+/9b0fe3d125f237d9884732a48414fa85fc71b4e3 > Committed: https://skia.googlesource.com/skia/+/b12b3c6908c62c908b3680be01e3b5bfd30de310 > Committed: https://skia.googlesource.com/skia/+/f008b0a59f45c0d4bea3e66faf3b01805009ec89 > Committed: https://skia.googlesource.com/skia/+/08b2ccf398e2b81bc05d2c105837e5419899469b > Committed: https://skia.googlesource.com/skia/+/dcfe6dba4a335e50e86ff68e3252065d4197432c > Committed: https://skia.googlesource.com/skia/+/ccb1dd8f267f9d7fe7c9d0ce222ebc81b41853b3 TBR=benjaminwagner@google.com,bsalomon@google.com,egdaniel@google.com,ethannicholas@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://skia.googlesource.com/skia/+/9df16b5e85ef37c44e02257e49eb996efca0e173

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+549 lines, -1445 lines) Patch
M bench/GLBench.h View 1 chunk +2 lines, -2 lines 0 comments Download
M bench/GLBench.cpp View 3 chunks +6 lines, -23 lines 0 comments Download
M bench/GLInstancedArraysBench.cpp View 2 chunks +3 lines, -1 line 0 comments Download
M bench/GLVec4ScalarBench.cpp View 2 chunks +3 lines, -1 line 0 comments Download
M bench/GLVertexAttributesBench.cpp View 3 chunks +4 lines, -2 lines 0 comments Download
M gyp/sksl.gyp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/gl/GrGLContext.h View 4 chunks +2 lines, -15 lines 0 comments Download
M src/gpu/gl/GrGLContext.cpp View 2 chunks +0 lines, -12 lines 0 comments Download
M src/gpu/gl/GrGLGpu.cpp View 4 chunks +35 lines, -9 lines 0 comments Download
M src/gpu/gl/builders/GrGLShaderStringBuilder.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/gpu/gl/builders/GrGLShaderStringBuilder.cpp View 4 chunks +7 lines, -123 lines 0 comments Download
M src/gpu/glsl/GrGLSLFragmentShaderBuilder.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/glsl/GrGLSLFragmentShaderBuilder.cpp View 2 chunks +5 lines, -5 lines 0 comments Download
M src/gpu/glsl/GrGLSLShaderBuilder.h View 1 chunk +14 lines, -18 lines 0 comments Download
M src/gpu/glsl/GrGLSLShaderVar.h View 1 chunk +7 lines, -3 lines 0 comments Download
M src/gpu/instanced/InstanceProcessor.cpp View 8 chunks +17 lines, -17 lines 0 comments Download
D src/sksl/README View 1 chunk +0 lines, -35 lines 0 comments Download
M src/sksl/SkSLCodeGenerator.h View 1 chunk +1 line, -1 line 0 comments Download
M src/sksl/SkSLCompiler.h View 3 chunks +0 lines, -5 lines 0 comments Download
M src/sksl/SkSLCompiler.cpp View 8 chunks +9 lines, -29 lines 0 comments Download
M src/sksl/SkSLContext.h View 2 chunks +0 lines, -2 lines 0 comments Download
M src/sksl/SkSLGLSLCodeGenerator.h View 4 chunks +2 lines, -14 lines 0 comments Download
M src/sksl/SkSLGLSLCodeGenerator.cpp View 11 chunks +25 lines, -187 lines 0 comments Download
M src/sksl/SkSLIRGenerator.h View 3 chunks +0 lines, -4 lines 0 comments Download
M src/sksl/SkSLIRGenerator.cpp View 13 chunks +17 lines, -65 lines 0 comments Download
M src/sksl/SkSLMain.cpp View 2 chunks +9 lines, -43 lines 0 comments Download
M src/sksl/SkSLParser.h View 2 chunks +1 line, -2 lines 0 comments Download
M src/sksl/SkSLParser.cpp View 10 chunks +23 lines, -59 lines 0 comments Download
M src/sksl/SkSLSPIRVCodeGenerator.h View 1 chunk +1 line, -1 line 0 comments Download
M src/sksl/SkSLSPIRVCodeGenerator.cpp View 5 chunks +4 lines, -21 lines 0 comments Download
M src/sksl/SkSLToken.h View 3 chunks +2 lines, -4 lines 0 comments Download
M src/sksl/SkSLUtil.h View 1 chunk +5 lines, -9 lines 0 comments Download
M src/sksl/SkSLUtil.cpp View 2 chunks +0 lines, -47 lines 0 comments Download
M src/sksl/ast/SkSLASTDeclaration.h View 1 chunk +1 line, -3 lines 0 comments Download
M src/sksl/ast/SkSLASTIndexSuffix.h View 1 chunk +3 lines, -13 lines 0 comments Download
M src/sksl/ast/SkSLASTLayout.h View 3 chunks +2 lines, -15 lines 0 comments Download
D src/sksl/ast/SkSLASTModifiersDeclaration.h View 1 chunk +0 lines, -37 lines 0 comments Download
D src/sksl/ast/SkSLASTPrecision.h View 1 chunk +0 lines, -45 lines 0 comments Download
M src/sksl/ir/SkSLIndexExpression.h View 3 chunks +3 lines, -3 lines 0 comments Download
M src/sksl/ir/SkSLIntLiteral.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/sksl/ir/SkSLLayout.h View 4 chunks +8 lines, -26 lines 0 comments Download
D src/sksl/ir/SkSLModifiersDeclaration.h View 1 chunk +0 lines, -37 lines 0 comments Download
M src/sksl/ir/SkSLProgram.h View 2 chunks +2 lines, -7 lines 0 comments Download
M src/sksl/ir/SkSLProgramElement.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/sksl/lex.sksl.c View 27 chunks +260 lines, -271 lines 0 comments Download
M src/sksl/sksl.flex View 2 chunks +1 line, -5 lines 0 comments Download
M src/sksl/sksl.include View 2 chunks +0 lines, -3 lines 0 comments Download
M src/sksl/sksl_frag.include View 1 chunk +1 line, -13 lines 0 comments Download
M tests/SkSLErrorTest.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/SkSLGLSLTest.cpp View 9 chunks +57 lines, -197 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
jvanverth1
Created Revert of Turned on SkSL->GLSL compiler
4 years, 2 months ago (2016-10-11 17:03:31 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2408193002/1
4 years, 2 months ago (2016-10-11 17:03:43 UTC) #3
commit-bot: I haz the power
4 years, 2 months ago (2016-10-11 17:03:59 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/9df16b5e85ef37c44e02257e49eb996efca0e173

Powered by Google App Engine
This is Rietveld 408576698